Move closeModal into finally block

WordPress · Nov 27, 2024 · 8bacdbb · 8bacdbb
1 parent d486bac
commit 8bacdbb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/editor/src/components/post-actions/set-as-homepage.js b/packages/editor/src/components/post-actions/set-as-homepage.js
@@ -65,7 +65,6 @@ const SetAsHomepageModal = ( { items, closeModal } ) => {
 				show_on_front: 'page',
 			} );
 
-			closeModal?.();
 			createSuccessNotice( __( 'Homepage updated' ), {
 				type: 'snackbar',
 			} );
@@ -76,6 +75,8 @@ const SetAsHomepageModal = ( { items, closeModal } ) => {
 					? typedError.message
 					: __( 'An error occurred while setting the homepage' );
 			createErrorNotice( errorMessage, { type: 'snackbar' } );
+		} finally {
+			closeModal?.();
 		}
 	}