Skip to content

Commit

Permalink
Menu.ItemHelpText: better line breaking (#67011)
Browse files Browse the repository at this point in the history
* Fix: Use break-word instead of break-all in attribute description

Changed break-all to use word-break for better readability.

* CSS: Replace deprecated word-break with overflow-wrap

Replace deprecated `word-break: break-word` with the modern equivalent
`overflow-wrap: anywhere` to handle text wrapping. This change maintains
the same text wrapping behavior while using the current standard CSS
property.

* Docs: Add changelog entry for MenuItemHelpText text wrapping fix

* Docs: Update changelog entry for Menu.ItemHelpText to internal section

Co-authored-by: himanshupathak95 <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: jasmussen <[email protected]>
  • Loading branch information
7 people authored Nov 21, 2024
1 parent e0d5ee6 commit 9a6f48b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

- `SlotFill`: fix dependencies of `Fill` registration effects ([#67071](https://github.com/WordPress/gutenberg/pull/67071)).
- `SlotFill`: rewrite the `Slot` component from class component to functional ([#67153](https://github.com/WordPress/gutenberg/pull/67153)).
- `Menu.ItemHelpText`: Fix text wrapping to prevent unintended word breaks ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).

## 28.12.0 (2024-11-16)

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/menu/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export const MenuItemHelpText = styled( Truncate )`
font-size: ${ font( 'helpText.fontSize' ) };
line-height: 16px;
color: ${ LIGHTER_TEXT_COLOR };
word-break: break-all;
overflow-wrap: anywhere;
[data-active-item]:not( [data-focus-visible] )
*:not( ${ MenuPopoverInnerWrapper } )
Expand Down

1 comment on commit 9a6f48b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 9a6f48b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11959083382
📝 Reported issues:

Please sign in to comment.