Skip to content

Commit

Permalink
Code quality: Remove uncessary BaseControl usage from video block
Browse files Browse the repository at this point in the history
  • Loading branch information
jorgefilipecosta committed Feb 28, 2019
1 parent 77a945c commit a96a3e0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
9 changes: 5 additions & 4 deletions packages/block-library/src/video/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
*/
import { getBlobByURL, isBlobURL } from '@wordpress/blob';
import {
BaseControl,
Button,
Disabled,
IconButton,
Expand Down Expand Up @@ -211,10 +210,12 @@ class VideoEdit extends Component {
] }
/>
<MediaUploadCheck>
<BaseControl
<div
className="editor-video-poster-control"
label={ __( 'Poster Image' ) }
>
<span>
{ __( 'Poster Image' ) }
</span>
<MediaUpload
title={ __( 'Select Poster Image' ) }
onSelect={ this.onSelectPoster }
Expand All @@ -234,7 +235,7 @@ class VideoEdit extends Component {
{ __( 'Remove Poster Image' ) }
</Button>
}
</BaseControl>
</div>
</MediaUploadCheck>
</PanelBody>
</InspectorControls>
Expand Down
5 changes: 5 additions & 0 deletions packages/block-library/src/video/editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,8 @@
.editor-video-poster-control .components-button + .components-button {
margin-top: 1em;
}

.editor-video-poster-control > span {
display: block;
margin-bottom: 4px;
}

0 comments on commit a96a3e0

Please sign in to comment.