Add mixed symbol value for bulk editing

WordPress · Dec 3, 2024 · c27bd65 · c27bd65
1 parent ac03ed1
commit c27bd65
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 4 deletions.
diff --git a/packages/dataviews/src/components/dataform/index.tsx b/packages/dataviews/src/components/dataform/index.tsx
@@ -10,6 +10,7 @@ import type { DataFormProps } from '../../types';
 import { DataFormProvider } from '../dataform-context';
 import { normalizeFields } from '../../normalize-fields';
 import { DataFormLayout } from '../../dataforms-layouts/data-form-layout';
+import { MIXED_VALUE } from '../../constants';
 
 /**
  * Loops through the list of data items and returns an object with the intersecting ( same ) key and values.
@@ -26,6 +27,8 @@ function getIntersectingValues< Item extends object >( data: Item[] ): Item {
 		} );
 		if ( intersects ) {
 			intersectingValues[ key ] = firstRecord[ key ];
+		} else {
+			intersectingValues[ key ] = MIXED_VALUE as Item[ keyof Item ];
 		}
 	}
 	return intersectingValues;

diff --git a/packages/dataviews/src/constants.ts b/packages/dataviews/src/constants.ts
@@ -68,3 +68,6 @@ export const sortIcons = {
 export const LAYOUT_TABLE = 'table';
 export const LAYOUT_GRID = 'grid';
 export const LAYOUT_LIST = 'list';
+
+// Dataform mixed value.
+export const MIXED_VALUE = Symbol.for( 'DATAFORM_MIXED_VALUE' );
diff --git a/packages/dataviews/src/dataforms-layouts/panel/index.tsx b/packages/dataviews/src/dataforms-layouts/panel/index.tsx
@@ -26,6 +26,7 @@ import type {
 import DataFormContext from '../../components/dataform-context';
 import { DataFormLayout } from '../data-form-layout';
 import { isCombinedField } from '../is-combined-field';
+import { MIXED_VALUE } from '../../constants';
 
 function DropdownHeader( {
 	title,
@@ -114,8 +115,7 @@ function PanelDropdown< Item extends object >( {
 	);
 
 	const fieldValue = fieldDefinition.getValue( { item: data } );
-	const showMixedValue =
-		isBulkEditing && ( fieldValue === undefined || fieldValue === '' );
+	const showMixedValue = isBulkEditing && fieldValue === MIXED_VALUE;
 
 	return (
 		<Dropdown

diff --git a/packages/dataviews/src/index.ts b/packages/dataviews/src/index.ts
@@ -4,3 +4,4 @@ export { VIEW_LAYOUTS } from './dataviews-layouts';
 export { filterSortAndPaginate } from './filter-and-sort-data-view';
 export type * from './types';
 export { isItemValid } from './validation';
+export { MIXED_VALUE as DATAFORM_MIXED_VALUE } from './constants';
diff --git a/packages/fields/src/fields/title/index.ts b/packages/fields/src/fields/title/index.ts
@@ -1,7 +1,7 @@
 /**
  * WordPress dependencies
  */
-import type { Field } from '@wordpress/dataviews';
+import { type Field } from '@wordpress/dataviews';
 import { __ } from '@wordpress/i18n';
 
 /**
@@ -16,7 +16,12 @@ const titleField: Field< BasePost > = {
 	id: 'title',
 	label: __( 'Title' ),
 	placeholder: __( 'No title' ),
-	getValue: ( { item } ) => getItemTitle( item ),
+	getValue: ( { item } ) => {
+		if ( typeof item.title === 'symbol' ) {
+			return item.title;
+		}
+		return getItemTitle( item );
+	},
 	render: TitleView,
 	enableHiding: false,
 };