Skip to content

Commit

Permalink
[Navigation screen] Replace component state and refs with Redux state (
Browse files Browse the repository at this point in the history
…#23033)

* Squash

* menu editor -> navigation editor

* Rename CSS classes and shortcuts components to reflect menu vs navigation

* "Privatize" concurrency-related actions

* Migrate to uuid module

* Remove persist: [ 'preferences' ]

* Remove processing-related selectors in favor of controls which are not a public API

* Wrap pending action in serializeProcessing()

* Rename processing to processingQueue

* Move the mapping back to state

* Remove general resolveSelect control

* Add undo/redo shortcuts

* Remove persist option in proper store

* Use the canonical way of keeping track of post resolution (and fix the rogue http query)

* Add comments

* Enforce menuId to be string

* Add unit tests for mapping reducer

* Add unit tests for processingQueue reducer

* Update comment on getNavigationPost selector

* Update comment on getNavigationPost

* Ensure POP_PENDING_ACTION action don't mutate the state

* Rename getNavigationPost to getNavigationPostForMenu

* Handle empty nonce in batchSave

* Don't export storeConfig

* Simplify useCallback

* Rename NavigationEditorWrapper to NavigationEditor

* Ensure menuId is a number

* Add comments for all exported members of store/**/*.js

* Add comments to exported members of utils.js

* Update package-lock.json
  • Loading branch information
adamziel authored Jun 22, 2020
1 parent f2ed972 commit d3015f4
Show file tree
Hide file tree
Showing 26 changed files with 1,196 additions and 536 deletions.
4 changes: 3 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/edit-navigation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"@wordpress/blocks": "file:../blocks",
"@wordpress/components": "file:../components",
"@wordpress/compose": "file:../compose",
"@wordpress/core-data": "file:../core-data",
"@wordpress/data": "file:../data",
"@wordpress/data-controls": "file:../data-controls",
"@wordpress/dom-ready": "file:../dom-ready",
Expand All @@ -48,7 +49,8 @@
"@wordpress/url": "file:../url",
"classnames": "^2.2.5",
"lodash": "^4.17.15",
"rememo": "^3.0.0"
"rememo": "^3.0.0",
"uuid": "^7.0.2"
},
"publishConfig": {
"access": "public"
Expand Down
71 changes: 0 additions & 71 deletions packages/edit-navigation/src/components/menu-editor/index.js

This file was deleted.

This file was deleted.

43 changes: 0 additions & 43 deletions packages/edit-navigation/src/components/menu-editor/shortcuts.js

This file was deleted.

This file was deleted.

Loading

0 comments on commit d3015f4

Please sign in to comment.