Navigation Link: Match Editor Markup to Rendered

Closes #28575
WordPress · Mar 17, 2021 · e42b20e · e42b20e
1 parent 2f1b4dc
commit e42b20e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -428,7 +428,9 @@ export default function NavigationLinkEdit( {
 				</PanelBody>
 			</InspectorControls>
 			<li { ...blockProps }>
-				<div className={ classes }>
+				{/* eslint-disable jsx-a11y/anchor-is-valid */}
+				<a className={ classes }>
+				{/* eslint-enable */}
 					{ ! url ? (
 						<div className="wp-block-navigation-link__placeholder-text">
 							<KeyboardShortcuts
@@ -550,7 +552,7 @@ export default function NavigationLinkEdit( {
 							/>
 						</Popover>
 					) }
-				</div>
+				</a>
 				{ hasDescendants && showSubmenuIcon && (
 					<span className="wp-block-navigation-link__submenu-icon">
 						<ItemSubmenuIcon />

diff --git a/packages/block-library/src/navigation-link/editor.scss b/packages/block-library/src/navigation-link/editor.scss
@@ -39,6 +39,10 @@
 		display: block;
 	}
 
+	.wp-block-navigation-link__content {
+		cursor: text;
+	}
+
 	&.is-editing,
 	&.is-selected {
 		min-width: 20px;