Framework: Disable aria required role props ESLint rule

Recommended combobox aria-controls is non-configurable and may recommend a poorer experience. See: #469 See: http://www.heydonworks.com/article/aria-controls-is-poop
WordPress · Oct 27, 2017 · f5a3622 · f5a3622
1 parent d58a96b
commit f5a3622
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -54,6 +54,7 @@
 		} ],
 		"jsx-a11y/media-has-caption": "off",
 		"jsx-a11y/no-noninteractive-tabindex": "off",
+		"jsx-a11y/role-has-required-aria-props": "off",
 		"jsx-quotes": "error",
 		"key-spacing": "error",
 		"keyword-spacing": "error",

diff --git a/blocks/url-input/index.js b/blocks/url-input/index.js
@@ -182,7 +182,6 @@ class UrlInput extends Component {
 					role="combobox"
 					aria-expanded={ showSuggestions }
 					aria-autocomplete="list"
-					aria-controls={ `blocks-url-input-suggestions-${ instanceId }` }
 					aria-owns={ `blocks-url-input-suggestions-${ instanceId }` }
 					aria-activedescendant={ selectedSuggestion !== null ? `blocks-url-input-suggestion-${ instanceId }-${ selectedSuggestion }` : undefined }
 				/>

diff --git a/components/form-token-field/token-input.js b/components/form-token-field/token-input.js
@@ -46,7 +46,6 @@ class TokenInput extends Component {
 				role="combobox"
 				aria-expanded={ isExpanded }
 				aria-autocomplete="list"
-				aria-controls={ `components-form-token-suggestions-${ instanceId }` }
 				aria-owns={ `components-form-token-suggestions-${ instanceId }` }
 				aria-activedescendant={ selectedSuggestionIndex !== -1 ? `components-form-token-suggestions-${ instanceId }-${ selectedSuggestionIndex }` : undefined }
 				aria-describedby={ `components-form-token-suggestions-howto-${ instanceId }` }