Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified toolbar mode hides document settings and general menu #10959

Closed
oandregal opened this issue Oct 23, 2018 · 3 comments · Fixed by #10990
Closed

Unified toolbar mode hides document settings and general menu #10959

oandregal opened this issue Oct 23, 2018 · 3 comments · Fixed by #10990
Assignees
@jasmussen
Labels
Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Milestone
4.2

Comments

@oandregal
Copy link
Member

When the "Unified toolbar" mode is activated, the document settings and the general menu are stretched wide to the point they are sent beyond the viewport.

Admin user screenshot:

unified-toolbar-quote-admin

Contributor user screenshot:

unified-toolbar-quote-contributor
@oandregal
Copy link
Member Author

cc @jasmussen @karmatosed

@oandregal oandregal added [Type] Bug An existing feature does not function as intended Needs Design Needs design efforts. labels Oct 23, 2018
@oandregal oandregal added this to the 4.2 milestone Oct 23, 2018
@jasmussen jasmussen self-assigned this Oct 24, 2018
@jasmussen
Copy link
Contributor

I'm going to fix this one, good ticket, thank you.

I would note that I feel like a key ingredient in fixing this, is to fix #4287 that is, either rewrite the document outline button, or merge it with the block navigation tool. This should free up a precious 52 pixels horizontally, which is a lot when real estate is premium.

For now I'm going to tighten up the margins a bit, and increase the breakpoint that makes the unified toolbar stack below the editor bar.

@jasmussen
Copy link
Contributor

CC: @mtias @alexislloyd

jasmussen pushed a commit that referenced this issue Oct 24, 2018
Fix issue with unified toolbar not fitting
5af7925 
Fixes #10959.

This PR fixes an issue where at certain viewport widths, there wouldn't be room for the unified toolbar between the icons on the left, and the buttons on the right, in the editor bar. It does so by:

- Reducing the padding between toolbar segments
- Introducing a new breakpoint, xlarge (1080px), that allows the toolbar to stay in the editor bar for longer, before it stacks.
@jasmussen jasmussen mentioned this issue Oct 24, 2018
Merged
jasmussen added a commit that referenced this issue Oct 25, 2018
@jasmussen
Fix issue with unified toolbar not fitting (#10990)
4b77281 
* Fix issue with unified toolbar not fitting

Fixes #10959.

This PR fixes an issue where at certain viewport widths, there wouldn't be room for the unified toolbar between the icons on the left, and the buttons on the right, in the editor bar. It does so by:

- Reducing the padding between toolbar segments
- Introducing a new breakpoint, xlarge (1080px), that allows the toolbar to stay in the editor bar for longer, before it stacks.

* Revert to fullheight separators.
antpb pushed a commit to antpb/gutenberg that referenced this issue Oct 26, 2018
@jasmussen @antpb
Fix issue with unified toolbar not fitting (WordPress#10990)
56bdc41 
* Fix issue with unified toolbar not fitting

Fixes WordPress#10959.

This PR fixes an issue where at certain viewport widths, there wouldn't be room for the unified toolbar between the icons on the left, and the buttons on the right, in the editor bar. It does so by:

- Reducing the padding between toolbar segments
- Introducing a new breakpoint, xlarge (1080px), that allows the toolbar to stay in the editor bar for longer, before it stacks.

* Revert to fullheight separators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
Needs Design Needs design efforts. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Fix issue with unified toolbar not fitting WordPress/gutenberg
2 participants
@oandregal @jasmussen