Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag & Drop Handle Alignment and Overlap with Short Blocks #11725

Closed
mrwweb opened this issue Nov 10, 2018 · 6 comments
Closed

Drag & Drop Handle Alignment and Overlap with Short Blocks #11725

mrwweb opened this issue Nov 10, 2018 · 6 comments
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@mrwweb
Copy link

mrwweb commented Nov 10, 2018

Describe the bug
This is especially notable with the separator/hr block, but any short block (shorter than ~80px) has strange handle alignment. In this case, it looks weird that the handle isn't centered with the block (even though that's not the handle alignment on other blocks). Worse, it overlaps with the next block's handle, making it very hard to select a specific handle and even confusing which block the handle belongs to.

Expected behavior
Any area on the screen which shows UI when hovered, does not overlap with any other hover area.

Screenshots
unclear and overlapping hover zones for drag and drop handles

Desktop (please complete the following information):
Win 10, Firefox 63, WP 5.0-beta3, no plugins, Twenty Nineteen

@designsimply designsimply added [Feature] UI Components Impacts or related to the UI component system Needs Testing Needs further testing to be confirmed. labels Nov 11, 2018
@designsimply
Copy link
Member

Tested and confirmed using Firefox 63.0.1 on macOS 10.13.6 that the block movers and drag handles can overlap and appear off-center for blocks less than 80px in height, such as the separator block.

screen shot 2018-11-12 at 10 04 41 am
Seen at http://alittletestblog.com/wp-admin/post.php?post=15677&action=edit running WordPress 4.9.8 and Gutenberg 4.3 using Firefox 63.0.1 on macOS 10.13.6.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later and removed Needs Testing Needs further testing to be confirmed. labels Nov 12, 2018
@mtias mtias added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Nov 21, 2018
@mtias mtias added this to the Future: 5.1 milestone Nov 21, 2018
@mapk
Copy link
Contributor

mapk commented Apr 2, 2019

What if we eliminate the drag option from blocks less than ~80px in height? So the separator block would look something like this:

no-drag

@mrwweb
Copy link
Author

mrwweb commented Apr 2, 2019

@mapk Is that because you don't think the use-case for dragging applies to short blocks?

@mapk
Copy link
Contributor

mapk commented Apr 4, 2019

@mrwweb, no. I'm sure the shorter blocks can benefit from dragging just as much as the other blocks. So that may be reason enough to not go that direction. I'm just suggesting it as a possible solution b/c it helps tighten up the arrows (which still allow for up/down movement and retains a11y), and it also helps prevent the other block movers from overlapping.

@mrwweb
Copy link
Author

mrwweb commented Apr 11, 2019

@mapk, in that case then I don't think that's the right solution. Part of me even hypothesizes that a section divider would is an especially useful thing to drag and drop.

As I mulled this over the other day, I had two potential ideas:

1. Use the Alignwide pattern for all drag handles:

horizontally organized Up, Handle, and Down buttons

2. Use some kind of "Handle-First" design

This would be a big change in behavior and require testing, but I wonder how it would look/feel if the default interface only shows the drag handle (the 6 dots) on hover/focus and then the up/down buttons appear when hovering or focusing the drag handle.

Hover/Focus state of a block only showing the "drag handle"

^^^ The handle would probably get top-aligned with the block.

Hover/Focus on the "drag handle" makes the up/down arrows appear

@mapk
Copy link
Contributor

mapk commented Sep 24, 2019

I believe this gets resolved with #17315. I'll close this out, but if I'm mistaken, just let me know and we can reopen it.

@mapk mapk closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants