Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Only show one set of block movers at a time. #16681

Closed
kjellr opened this issue Jul 19, 2019 · 4 comments
Closed

Suggestion: Only show one set of block movers at a time. #16681

kjellr opened this issue Jul 19, 2019 · 4 comments
Assignees
@epiqueras
Labels
[Feature] Blocks Overall functionality of blocks [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 19, 2019

Currently, if you have a nested child or parent block selected, and then hover over adjacent blocks, you'll see two sets of block movers:

Screen Shot 2019-07-19 at 9 27 10 AM

GIF:

overlap

This is really confusing, and looks broken. We should try only showing one set of block movers at a time, in order to prevent this overlap.
@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Jul 19, 2019
@swissspidy
Copy link
Member

This is not limited to nested blocks, happens with regular blocks too:

Screenshot 2019-07-19 at 15 44 20

@swissspidy swissspidy added the [Feature] Blocks Overall functionality of blocks label Jul 19, 2019
@kjellr
Copy link
Contributor Author

kjellr commented Jul 19, 2019

Good point. This is also related to #11725

@karmatosed
Copy link
Member

Totally agree we should bring in more consistently showing only one of any type of interactive element at a time, of any.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 19, 2019
@epiqueras epiqueras self-assigned this Jul 24, 2019
@epiqueras epiqueras added the [Package] Block editor /packages/block-editor label Jul 24, 2019
@epiqueras epiqueras added this to the Gutenberg 6.2 milestone Jul 24, 2019
@epiqueras epiqueras mentioned this issue Jul 24, 2019
Closed
5 tasks
@gziolo gziolo removed this from the Gutenberg 6.2 milestone Jul 30, 2019
@jasmussen jasmussen mentioned this issue Aug 12, 2019
Closed
@kjellr kjellr mentioned this issue Sep 3, 2019
Merged
@kjellr
Copy link
Contributor Author

kjellr commented Sep 25, 2019

Closed via #17315.

@kjellr kjellr closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epiqueras epiqueras

Labels
[Feature] Blocks Overall functionality of blocks [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Block Editor: Only show block movers when block is selected. WordPress/gutenberg
5 participants
@karmatosed @gziolo @swissspidy @kjellr @epiqueras