Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for PHP 5.2 and 5.3 #15796

Closed
gziolo opened this issue May 23, 2019 · 1 comment
Closed

Remove support for PHP 5.2 and 5.3 #15796

gziolo opened this issue May 23, 2019 · 1 comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Comments

@gziolo
Copy link
Member

gziolo commented May 23, 2019

Replaces #13393.

We can safely remove the following files now:

• https://github.com/WordPress/gutenberg/blob/master/bin/patches/node.patch
• https://github.com/WordPress/gutenberg/blob/master/bin/patches/openssl.patch

In addition, we should update all scripts to work with PHP 5.6+. Travis config should be updated as well.
@gziolo gziolo added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label May 23, 2019
@gziolo gziolo mentioned this issue May 23, 2019
Closed
@swissspidy swissspidy mentioned this issue May 24, 2019
Merged
@Soean Soean mentioned this issue May 24, 2019
Merged
@swissspidy swissspidy mentioned this issue May 27, 2019
Closed
@gziolo gziolo added Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Aug 12, 2019
@gziolo
Copy link
Member Author

gziolo commented Aug 30, 2019

I think it was accomplished by @pento as a side-effect of working on #17004 :)

@gziolo gziolo closed this as completed Aug 30, 2019
@gziolo gziolo removed the Needs Dev Ready for, and needs developer efforts label Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gziolo