Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping blocks on non-consecutive multi-selection. #16902

Open
senadir opened this issue Aug 5, 2019 · 4 comments
Open

Grouping blocks on non-consecutive multi-selection. #16902

senadir opened this issue Aug 5, 2019 · 4 comments
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Type] Enhancement A suggestion for improvement.

Comments

@senadir
Copy link
Contributor

senadir commented Aug 5, 2019

related to this PR #16811
follow up to #16895

this issue handle the design selection of grouping multi-selection non-consecutive blocks, there are three possible outcomes:

  • grouping to the first selected Element (my prefered choice)
  • grouping to the last selected Element
  • grouping to the highest Element on the list

below are some gifs & prototypes to live test

- Grouping: First Selected
grouping:first-selected

- Grouping: Last Selected
grouping:last-selected

- Grouping: Highest Selected

grouping:highest-selected

@senadir senadir added Needs Design Feedback Needs general design feedback. [Feature] Block Multi Selection The ability to select and manipulate multiple blocks labels Aug 5, 2019
@mapk
Copy link
Contributor

mapk commented Aug 5, 2019

Hey @senadir, thanks for thinking through this interaction! I'm a bit confused by wording being used here though. You're proposing questions around how someone might "group" these together. Immediately, I start thinking of these blocks getting appended to a Group block. But I'm not sure that's what you're asking because I don't see a Group block in the gifs.

I think you're offering ways in which these non-consecutive blocks become consecutive. So ultimately it looks like we have two interactions for handling these non-consecutive blocks.

  1. How do we make them become consecutive? (this issue Grouping blocks on non-consecutive multi-selection. #16902)
  2. How do we move them together? (Moving blocks on non-consecutive multi-selection. #16895 )

My experience with this leads me to think of layers within a graphics program like Adobe Photoshop, Sketch or even Figma. In these applications, there's no real way to just make the non-consecutive layers become consecutive. And selecting non-consecutive layers is more about moving these layers somewhere in the tree.

Photoshop
photoshop-layers

Sketch
sketch-layers

For this reason, I'm not sure a "grouping" feature is needed for bringing non-consecutive blocks inline with each other. Maybe the issue #16895 is enough to handle what needs handling?

Any thoughts? Am I missing something?

If this is in deed about taking non-consecutive blocks and Grouping them into a Group block, well then I'm completely off... and I like Grouping where the highest selected block resides.

@senadir
Copy link
Contributor Author

senadir commented Aug 5, 2019

@mapk

... I start thinking of these blocks getting appended to a Group block

that's exactly what I'm trying to demonstrate, it's more about when you select a group of non-consecutive elements, group them using a button or a shortcut, where will this new group block be? will it be in the place of the first element selected? the last element selected or the highest element in them.

I'm feeling that first & last element are the more inutive ones since you start with it or finish with it, but I'm not really sure so that's why I created those examples

I've updated the gifs to demonstrate a grouping behavior

as for having two issues open, well it's actually something of problem in me 😅 I'm a person who is deeply interested in micro transactions & subtle changes, I created those two issues the moment I discovered that there is more than one approach to solve them.

please feel free to close the issues if you deem them unnecessary.

@mapk
Copy link
Contributor

mapk commented Aug 6, 2019

Excellent! The issue is necessary, my apologies for not quite following initially.

In this case, I like the grouping to happen at the first element selected. That works well.

@mapk mapk removed the Needs Design Feedback Needs general design feedback. label Aug 6, 2019
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 4, 2023
@ellatrix
Copy link
Member

Not sure I understand this issue because right now, it's not possible to have non-consecutive selection. Should it be closed in favour of #16797?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants