Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UrlInput component is not accessible #1855

Closed
afercia opened this issue Jul 11, 2017 · 1 comment
Closed

The UrlInput component is not accessible #1855

afercia opened this issue Jul 11, 2017 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Jul 11, 2017

The UrlInput component added in 4dc462c to support optional links in image blocks, is made of two buttons and one input field:

screen shot 2017-07-11 at 20 22 49

The two buttons are "empty": there's no text or aria-label that assistive technologies can announce. Screen reader will read out just "button".

A very basic requirement for web standards and accessibility is that all user interface controls need to be labeled.

In this case, an aria-label with a meaningful text would be ok.

The input field misses a properly associated label. All input fields need to be associated with a label, that can be visually hidden. Alternatively, they can use an aria-label attribute. Placeholders are not a replacement for labels.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 11, 2017
@afercia
Copy link
Contributor Author

afercia commented Aug 1, 2017

Fixed in #1856

@afercia afercia closed this as completed Aug 1, 2017
Tug pushed a commit that referenced this issue Feb 28, 2020
…-options

Enable gallery upload options in production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

1 participant