Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The post content shifts to the right when publishing #19840

Closed
afercia opened this issue Jan 23, 2020 · 1 comment · Fixed by #19843
Closed

The post content shifts to the right when publishing #19840

afercia opened this issue Jan 23, 2020 · 1 comment · Fixed by #19843
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 23, 2020

Describe the bug
When publishing a new post, the whole post content shifts to the right producing an unexpected movement of the whole content section.

As a user, I'd be very confused by things moving while I publish and I'd wonder if something went wrong.

Having the whole editor unexpectedly moving doesn't seem an optimal user experience.

GIF:

centered

To reproduce
This happens only on WordPress trunk, with or without the Gutenberg plugin activated. Doesn't happen on 5.3.2.

  • create a post
  • make sure the Gutenberg Settings sidebar is expanded
  • enter a title
  • enter some content
  • click Publish
  • the content area shifts to the right
  • the publish sidebar appears
  • click the Publish button within the publish sidebar
  • the content area is still shifted to the right
  • close the publish sidebar by clicking on the X button
  • the content area shifts back to its original position

Expected behavior
To not see the whole editor area move

Additional context

This seems related to the changes from #18044

Previously, the Editor content area had a right margin equal to the sidebar width. With the refactoring from #18044 the margin is gone.

@afercia afercia added the [Type] Bug An existing feature does not function as intended label Jan 23, 2020
@draganescu
Copy link
Contributor

draganescu commented Jan 23, 2020

I can confirm this behavior. It is not easy to add the margin back, as now the sidebar is removed from dom and the post content has no special class to select for that situation. And I think the problem is that the sidebar should not be removed by the publish panel being open, it should simply remain under it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants