Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill script code causes PHP notices #2137

Closed
nylen opened this issue Aug 1, 2017 · 1 comment · Fixed by #2139
Closed

Polyfill script code causes PHP notices #2137

nylen opened this issue Aug 1, 2017 · 1 comment · Fixed by #2139

Comments

@nylen
Copy link
Member

nylen commented Aug 1, 2017

cc @aduth

The code added in #2041 is generating PHP notices on Travis builds, and probably also on actual installations. Example:

PHP Notice: Undefined index: promise in /home/travis/build/WordPress/gutenberg/lib/client-assets.php on line 57
PHP Notice:  Trying to get property of non-object in /home/travis/build/WordPress/gutenberg/lib/client-assets.php on line 57

This should be resolved by first adding a failing test case. Simply calling this code and performing a basic assertion should be sufficient; PHPUnit will fail the test if a notice occurs.
@aduth aduth mentioned this issue Aug 1, 2017
Merged
@nylen
Copy link
Member Author

nylen commented Aug 1, 2017

probably also on actual installations

Probably not, because as noted in #2139, this is related to the GUTENBERG_LOAD_VENDOR_SCRIPTS constant used during test suite runs.

ceyhun pushed a commit that referenced this issue Jun 17, 2020
@Stojdza @rachelmcr
[UI tests] Run canaries on a PR and optionally full suite (#2137)
c38c98d 
* Run jest with --forceExit and --detectOpenHandles

* Hold full suite execution while it's not approved

* Ignore only develop branch

* fix spaces

* pointless commit

* Try different approach

* Fix Indentation

* Revert pointless commit

* Missed "-canary"

* Increase no_output_timeout to 20m

* Try with 'is-canary' parameter

* Move parameters

Co-authored-by: Rachel McR <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore missing handle in registered script polyfill WordPress/gutenberg
1 participant
@nylen