Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Mode on a block basis #2219

Closed
StaggerLeee opened this issue Aug 4, 2017 · 6 comments
Closed

Text Mode on a block basis #2219

StaggerLeee opened this issue Aug 4, 2017 · 6 comments
Labels
[Feature] Code Editor Handling the code view of the editing experience [Type] Question Questions about the design or development of the editor.

Comments

@StaggerLeee
Copy link

StaggerLeee commented Aug 4, 2017 •
edited
Loading

Would like to ask for a toolbar button to switch to text mode per a block ?

Now when you guaranty blocks are isolated and comparted I think we can have it.
It would come handy for instance when Table block is giving problems to switch to text mode and inspect block. Or iframe, or anything. Troubleshoot what HTML a shortcode (block) display.

Before in TinyMce you never knew where it would end, and global Text mode had its logic. Now with all block separation we can switch to Text mode per a block.
One notice despite, it would need to be filterable to show Text mode button to Admins only.
@aduth
Copy link
Member

aduth commented Aug 4, 2017

This could be a neat alternative for Text mode altogether even.

@aduth aduth added [Type] Question Questions about the design or development of the editor. [Feature] Code Editor Handling the code view of the editing experience labels Aug 4, 2017
@karmatosed
Copy link
Member

I almost feel this is worthy of a user test, in the sense of how better is an all in one mode over having it per block? My gut says that per block is not needed, it's almost too much. Text mode is an advanced feature and seeing it there each time could be added noise for typical users.

@StaggerLeee
Copy link
Author

StaggerLeee commented Aug 4, 2017 •
edited
Loading

Hi. That is why I said as button for Admins. I agree it would be stupid to force this button under Users noses unnecessary all the time. Probably would be one of the most unneeded buttons around.

Much of contradicting wishes here on Github could be solved by one new Settings Page for Gutenberg. Some options, decide what different roles see. We have to wait for some plugin as AdvancedTinyMce to come. (Not even that had Role based configuration)

What to do now, you change revolutionary with Gutenberg. On other side you stay steadily as rock, to not make any new Settings page options. Not even hidden as old "Link Manager".

@hedgefield
Copy link

Is the per-block Edit HTML option that was recently added sufficient to complete this request?

@aduth
Copy link
Member

aduth commented Oct 19, 2017

Yes, I think this can be considered closed by #2797.

Also: #2794

@aduth aduth closed this as completed Oct 19, 2017
@StaggerLeee
Copy link
Author

StaggerLeee commented Oct 19, 2017 •
edited
Loading

More than sufficient. Thank you.

Please reconsider to automatically switch all HTML previews to default visual blocks when User clicks outside blocks.
I can bet in my arm and see already now how beginners edit directly HTML code, thinking they did something wrong by copy-pasting, or typing.

Tug pushed a commit that referenced this issue May 12, 2020
@pinarol
Remove subscription button from blog template (#2219)
d995a69 
* Update gutenberg ref

* Add release notes

* Update gutenberg ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Code Editor Handling the code view of the editing experience [Type] Question Questions about the design or development of the editor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karmatosed @aduth @hedgefield @StaggerLeee