Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS Class issue with Spacer Block #22892

Closed
munirkamal opened this issue Jun 4, 2020 · 5 comments
Closed

CSS Class issue with Spacer Block #22892

munirkamal opened this issue Jun 4, 2020 · 5 comments
Labels
[Block] Spacer Affects the Spacer Block [Type] Bug An existing feature does not function as intended

Comments

@munirkamal
Copy link
Contributor

Like all other blocks the CSS class is not applied to the spacer block inside Gutenberg Editor. It is applied on the front-end but not when inside Gutenberg editor.
@richtabor richtabor added [Block] Spacer Affects the Spacer Block [Type] Bug An existing feature does not function as intended labels Jun 4, 2020
@richtabor
Copy link
Member

Confirmed.

Editor:
Screen Shot 2020-06-04 at 12 37 41 PM
Frontend:
Screen Shot 2020-06-04 at 12 37 29 PM

@thetwopct
Copy link

Related to this I presume, if I register_block_style for core/spacer (I have responsive spacers of different heights), the style is applied on the frontend, but not in the Editor as the class from the style is not added. Would be great to fix. Thanks!

@richtabor
Copy link
Member

Related to this I presume, if I register_block_style for core/spacer (I have responsive spacers of different heights), the style is applied on the frontend, but not in the Editor as the class from the style is not added. Would be great to fix. Thanks!

Very likely that this is related.

@oxyc
Copy link
Member

oxyc commented Jun 17, 2020

#23235 should fix all the issues mentioned here.

@thetwopct
Copy link

@oxyc how did you get on with the fix for this?

mkaz pushed a commit to oxyc/gutenberg that referenced this issue Oct 19, 2020
@oxyc @mkaz
Fix WordPress#22892 and print classnames in spacer block on editor side
ccc6057
@mkaz mkaz closed this as completed in c5e1b4d Oct 19, 2020
youknowriad added a commit that referenced this issue Nov 4, 2020
@youknowriad
Revert "Fix #22892 and print classnames in spacer block on editor side (
9b661ed 
#23235)"

This reverts commit c5e1b4d.
youknowriad added a commit that referenced this issue Nov 5, 2020
@youknowriad
Revert "Fix #22892 and print classnames in spacer block on editor side (
8582893 
#23235)" (#26682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Spacer Affects the Spacer Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oxyc @richtabor @munirkamal @thetwopct