Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List block: Add typography options #25725

Closed
alaczek opened this issue Sep 30, 2020 · 5 comments
Closed

List block: Add typography options #25725

alaczek opened this issue Sep 30, 2020 · 5 comments
Labels
[Block] List Affects the List Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@alaczek
Copy link

alaczek commented Sep 30, 2020

List block is missing font size controls. I was thinking it would be useful to have the same typography options available as in the paragraph block.

Paragraph block typography settings for reference:

image

@talldan talldan added [Block] List Affects the List Block [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Sep 30, 2020
@talldan
Copy link
Contributor

talldan commented Sep 30, 2020

I've added Needs Design Feedback as I'm not sure whether the lack of these options is for a reason, or whether it's just a missing feature. If design folks agree it's the latter then I think we can add the Needs Dev and Good First Issue labels to this one.

@paaljoachim
Copy link
Contributor

Hmm I believe there was some discussion a while ago in relation to adding options such a typography to other blocks. I am pinging a few folks who might remember some more details than what I currently do.
@kjellr @ItsJonQ @karmatosed

@kjellr
Copy link
Contributor

kjellr commented Oct 5, 2020

As discussed in #8171, the list block should definitely have the same typography controls as the paragraph block.

@paaljoachim
Copy link
Contributor

paaljoachim commented Oct 6, 2020

As you Dan suggested, I will go ahead and add a Needs dev and the Good First Issue label, and remove the Needs Design Feedback label.

@paaljoachim paaljoachim added Needs Dev Ready for, and needs developer efforts Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed Needs Design Feedback Needs general design feedback. labels Oct 6, 2020
@annezazu
Copy link
Contributor

annezazu commented Nov 5, 2020

Closing this out since #26257 has now been merged.

@annezazu annezazu closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants