Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typography options to list component #26257

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

kirilzh
Copy link
Contributor

@kirilzh kirilzh commented Oct 19, 2020

Description

Addresses: #25725

Adds typography controls to the list block.

Screenshots

image

Types of changes

Non-breaking change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@kirilzh kirilzh added the [Block] List Affects the List Block label Oct 19, 2020
@kirilzh kirilzh requested review from aristath and ItsJonQ October 20, 2020 07:03
@skorasaurus
Copy link
Member

Thanks for the contribution; I briefly tested the options; (I didn't use a block-based theme that would use theme.json; just used twentytwenty and maxwell themes) and it works as expected.

The ability for users to access block options like this should be programmatically controlled and that
should/could be addressed in #20588

@paaljoachim
Copy link
Contributor

The user interface looks good. Thank you for adding the typography panel to the List block, Kiril!

Before:
Screen Shot 2020-10-21 at 11 37 21

After:
Screen Shot 2020-10-21 at 11 39 23

@ItsJonQ
Copy link

ItsJonQ commented Nov 4, 2020

@kirilzh Thanks for adding this 🎉 .

I tested it locally. For some reason, only the custom font size is working for me. The FontSizePicker doesn't allow for me to choose a different size (e.g. "Small").

This may very well be that my local dev environment is messed up and unhappy.

To double check, would someone be able to confirm that the changing the font-size to preset values work? (e.g. Small or Large)

Thanks!


Update

It's working. It was just my local development that was wonky.

Copy link

@ItsJonQ ItsJonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 from me! Tested locally, and the FontSize controls are working for the List block (as expected).

Thank you @kirilzh !

@ItsJonQ ItsJonQ merged commit 8ac00fa into WordPress:master Nov 4, 2020
@github-actions github-actions bot added this to the Gutenberg 9.4 milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants