Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent string capitalization. #27085

Closed
talldan opened this issue Nov 19, 2020 · 4 comments
Closed

Inconsistent string capitalization. #27085

talldan opened this issue Nov 19, 2020 · 4 comments
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance

Comments

@talldan
Copy link
Contributor

talldan commented Nov 19, 2020

Describe the bug
I've noticed some inconsistent strings in the UI that could be improved.

The guide we're using is here - https://developer.wordpress.org/block-editor/contributors/document/copy-guide/#five-pay-attention-to-capitalization. It mentions that feature names are capitalized. It says 'feature labels' are sentence case. It doesn't show a feature name in a feature label, so this situation is unclear and open to interpretation.

In some places in the UI, features are capitalized:

  • Welcome Guide (in the editor options menu)
  • Block Manager (in the editor options menu)
  • Reusable Block (the block's name. This also seems to be the only block suffixed 'Block', if that were dropped the use of 'Reusable block' elsewhere would seem to be ok)

In other places, they're sentence case (see almost everything in the editor options menu). Many of these seem as much 'features' as the Welcome Guide and Block Manager, especially the last four:

  • Top toolbar
  • Spotlight mode
  • Fullscreen mode
  • Visual editor
  • Code editor

When used in sentences, feature names are handled inconsistently:

  • Manage all reusable blocks
  • Add to Reusable blocks
  • Show More Settings

Then there are some that are easy fixes:

  • Insert Before (should be 'Insert before')
  • Insert After (should be 'Insert after')
  • Move To (should be 'Move to')

To reproduce
Steps to reproduce the behavior:

  1. Visit various parts of the UI

Expected behavior
Consistent capitalization.

@talldan talldan added [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Nov 19, 2020
@talldan
Copy link
Contributor Author

talldan commented Nov 19, 2020

Lots of these were changed in #18758, but I think that probably didn't go far enough, so it'd be good to iterate again.

@clucasrowlands
Copy link

clucasrowlands commented Nov 19, 2020

Our team (Editorial) doesn't have a full picture of styling and capitalization in the UI (we only get glimpses into the interface from occasional Github copy review pings like this!), so I hesitate to offer specific feedback on what to do here. But I'll share general suggestions from our POV.

In general, we follow these guidelines for feature names/dashboard sections (title case) and feature labels (sentence case).

Specifically for different blocks, in editorial and marketing copy (e.g., en.blog announcements), we've been capping the name of the block but lowercasing "block" (e.g., Reusable block, Premium Content block).

"Visual editor" and "Code editor" are interesting — we've generally been going with the "block editor" everywhere (marketing, social, etc.), so wouldn't it make sense and be consistent to lowercase those, too? (I don't have an answer to that!)

"Top toolbar" and types of modes (spotlight, fullscreen, dark, etc.) seem broad and generic enough (like "dashboard") to lowercase as well -- but again, I'm not well-versed in all existing UI copy to make definitive suggestions.

@talldan
Copy link
Contributor Author

talldan commented Feb 2, 2021

Some of these were changed in #28486 to be more consistent:

  • Insert Before (changed to 'Insert before')
  • Insert After (changed to 'Insert after')
  • Move To (changed to 'Move to')
  • Show More Settings (change to 'Show more settings')

So I think that mainly leaves the Reusable Blocks copy as being inconsistent:

  • Manage all reusable blocks
  • Add to Reusable blocks

@ntsekouras
Copy link
Contributor

Closing as the remaining Reusable related labels have been changed here: #29040, #27026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

No branches or pull requests

3 participants