Try: Polish block menu and show only fills when available. #28486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Copy
|
Size Change: +72 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Jan 26, 2021
packages/block-editor/src/components/block-settings-menu-controls/index.js
Outdated
Show resolved
Hide resolved
…ols/index.js Co-authored-by: Greg Ziółkowski <[email protected]>
jasmussen
commented
Jan 26, 2021
| return ( | ||
| <MenuGroup> | ||
| { fills } | ||
| <ConvertToGroupButton |
There was a problem hiding this comment.
Question, this Convert to Group button is now wrapped in the same fills?.length condition. Is that appropriate?
There was a problem hiding this comment.
I missed that to be honest. It will require some tweaks. @ntsekouras, can you help? This convert to buttons part is also optional 🙃
There was a problem hiding this comment.
I figured it might be tricky 🙈 — that's why I kept this in a draft state. But hopefully this will get the ball rolling, because the empty menu group is not great, I imagine for screenreaders either.
There was a problem hiding this comment.
It might be fine with screenreaders since there are no focusable items inside the group. I speculate though. It's an issue that can be and should be addressed 😄
There was a problem hiding this comment.
I created a new hook for this here: 7429243
shaunandrews
approved these changes
Jan 27, 2021
| </MenuItem> | ||
| </> | ||
| ) } | ||
| { ! isLocked && ( | ||
| <MenuItem | ||
| onClick={ flow( onClose, onMoveTo ) } | ||
| > | ||
| { __( 'Move To' ) } | ||
| { __( 'Move to' ) } |
|
I guess it's ready, @ntsekouras can you confirm? |
@gziolo - Yes, I just wanted someone else to review my approach with the new hook :) |
|
If it works, then ship it. Ideally, we would use fills for every menu items in the group to have unified handling, but it creates the chicken and egg dilemma 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR does two things:
Number 2 needs a serious sanity check, while it works fine in this PR, I believe there's something about the logic that's off.
Before:
After: