Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link popover appears "above" modals #29158

Closed
shaunandrews opened this issue Feb 19, 2021 · 1 comment
Closed

Link popover appears "above" modals #29158

shaunandrews opened this issue Feb 19, 2021 · 1 comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended z-index Discussions related to CSS z-index stacking.

Comments

@shaunandrews
Copy link
Contributor

If you click a link in a paragraph, a little popover appears that displays the link's URL and an button to edit the link. While this popover is open, you can then also open a modal. When both a popover and a modal are displayed at the same time, their z-index conflicts:

image

This is because both the popover and modal components have the same z-index of 1000000:

image

I suggest we update the z-index for the modal component (found here:

".components-modal__screen-overlay": 100000,
) to 1000001.

@shaunandrews shaunandrews added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system z-index Discussions related to CSS z-index stacking. labels Feb 19, 2021
@shaunandrews shaunandrews changed the title Link popover appears _above_ modals Link popover appears "above" modals Feb 19, 2021
@annezazu
Copy link
Contributor

annezazu commented Feb 7, 2022

From what I can see, this is no longer the case with the new preferences modal (tried with keyboard shortcuts and the welcome guide too):

Screen Shot 2022-02-07 at 12 17 09 AM

Going to close this out as a result!

@annezazu annezazu closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended z-index Discussions related to CSS z-index stacking.
Projects
None yet
Development

No branches or pull requests

2 participants