-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Appender: Add select-state before showing inserter #33025
Comments
That is really nice, Joen! Going through the issue step by step. The new approach in re-selecting a container kind of block. As an example I use the Group block. None selected state. We are able to right away see which block this is by the label that is added inside the boundary lines of the block. Reselecting Group block. We assume the user wants to right away add inner content. Reselecting Group block. It gives a stronger sense of hierarchy informing the user by the initial click that the parent container is selected. The user can then click the + to add the inner content. Looking at the #32108 issue where de-selecting and reselecting a template part in a new page template is identical to the re-selection process of the Group block as seen above. As with the Group block re-selecting a template part would also benefit from the new suggested method. Looking at #30116 and #30115 issues where one has added a link but want to delete it, but find it difficult to select the Add a link block added to the Navigation. Default not selected state. Default not selected state. Clicking the Add a link block (Selected state): Clicking the Add a link block (Selected state): One clicks the Add a link (block). Block is selected. One can click backspace on the keyboard to remove the link, the 3 dot ellipsis drop down menu to remove the block, or click the + sign to open up the inline inserter to add a menu item. In a sense this becomes a kind of click through state. Initial click selects the top parent or existing block. User selects to dig into the block by clicking the + or if content is present clicks again to gain access to inner content. |
It would be great with some feedback on this issue: @critterverse @javierarce @shaunandrews |
I like this solution, especially as it gives a little bit more context to the user, but I miss a couple of things in the prototype:
|
Really love this exploration. The only thing that immediately came to mind is how best to make this distinct from placeholders for theme blocks. At first glance, I could see folks getting confused there. |
To an extent, an empty group can be considered a placeholder, which in part helped inform this idea. |
What problem does this address?
The default appender component makes it easy to insert a block in its place. But it makes it hard to select the block itself:
Additionally, since this particular appender serves as a de-facto placeholder/setup state for some blocks (shown here, empty column and group blocks), the single bare plus icon is perhaps insufficient indication of what you're looking at.
#32108 discusses the same problem and how it affects the Template Part block, and a solution being discussed in the comments: build in a selection state before the insertion stage (aka. "clickthrough"):
What is your proposed solution?
Today, preinserted groups and columns look like this:
By adding a selection state first, that resting can state serve both as block indication and clickable area. A click here would surface the inserter:
Here's a basic prototype:
This select the block first, then insert behavior would fix the issue described in #32108. #30116 and #30115 are adjacent, but it's not clear if this pattern will work in those cases.
The text was updated successfully, but these errors were encountered: