Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Make it clearer how to delete a Link Block without a link #30116

Closed
Tracked by #35521
annezazu opened this issue Mar 22, 2021 · 3 comments
Closed
Tracked by #35521
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

Currently, if you add a link block to the navigation block but don't add a link, it results in a pretty confusing experience if you want to then delete the same link block. This is likely to be a common interaction for users though as they look to build out menus (trying out adding items, removing them, changing their minds mid adding a block, etc). The current experience gave the impression that one couldn't delete the block without adding a link first in order to get rid of the link UI:

When adding a Link block you cannot remove it without clicking on Add a link – I’d like to select the block without having to bring up the Link UI.

In the video, I obviously know it's possible to delete the link block but this seems to be a point of confusion if you aren't as familiar and could easily come up if someone adds a link but then changes their mind.

delete.link.block.mov

This came up as part of feedback for the third call for testing for the FSE Outreach Program.

What is your proposed solution?

While it makes sense to nudge a user to add a link in this context, there also needs to be a way to easily select the block without immediately throwing the user into the link UI controls as that seems to make it harder to feel one can then delete the block outright. This might mean a "double click" interaction, for example. I trust design here!

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block labels Mar 22, 2021
@jasmussen
Copy link
Contributor

Great ticket, valid feedback, thank you. As noted on another ticket, it's tricky because it is key to the menu item placeholder that it opens immediately on click/close, and that if you press Escape, the URL dialog closes and the block is selected so you can delete it.

I don't think either of the following are good solutions, but sharing in case they inspire better ideas:

  • Clicking the button selects it, you have to click an Edit icon next to it to add a link.
  • Clicking the button selects it, you have to press the URL button in the toolbar to add a link.
  • There's a close button on the URL dialog.

@getdave
Copy link
Contributor

getdave commented Nov 12, 2024

@annezazu @jasmussen Recent improvements to the Nav block (6.5?) mean that it's now much harder to end up with an empty link. Indeed we actively optimise to avoid this scenario.

Screen.Capture.on.2024-11-12.at.10-37-19.mp4

Do you think this warrants this Issue being closed out?

@annezazu
Copy link
Contributor Author

Yes, I do! Let's close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants