Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing navigation block inserter menu / block library #33867

Closed
talldan opened this issue Aug 4, 2021 · 8 comments
Closed

Confusing navigation block inserter menu / block library #33867

talldan opened this issue Aug 4, 2021 · 8 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback.

Comments

@talldan
Copy link
Contributor

talldan commented Aug 4, 2021

What problem does this address?

The navigation block has a problem where it has a lot of inner block types and variations that aren't very well organised:
Screenshot 2021-08-04 at 4 32 20 pm

Most of the time the user will want to insert either a link or maybe create a submenu as primary actions (#33775) and in less frequent cases add social icons or a search bar.

As seen in the screenshot, there are lots of variations of the navigation link and the right option isn't always clear. Sorting by commonly used blocks also isn't necessarily helpful here because there are so many types that it's easy for something important to drop out of the top 6.

What is your proposed solution?

There are two things that might help:

  • Allow the sort order of blocks in the quick inserter to be predefined. (e.g. Link and Dropdown always stay as the first two)
  • Make the process for inserting variations a two-step process. First a user would select 'Link' as the type of block they want to insert, and then the quick inserter could show the various types of link, they might choose 'Post Link' or 'Page Link' at that step. Essentially the main 'Link' block type in the quick inserter almost acts as a folder of variations.

Update: Other solutions

I'm updating this description with some of the other solutions being discussed in the comments of this and other issues as they come up:

@talldan talldan added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Block] Navigation Affects the Navigation Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature Needs Design Feedback Needs general design feedback. labels Aug 4, 2021
@getdave
Copy link
Contributor

getdave commented Aug 4, 2021

Going to copy/paste my thoughts we discussed in WP Slack https://wordpress.slack.com/archives/C01KDAZJMQ9/p1628066836003800.

Possibly slightly off topic and may require another issue - let me know what you think?

Quick thought: why can’t we just make the link UI more intelligent and avoid asking users to have to select so many things?

I mean…why do I need to know the difference between Post and Page.

I can’t tell you how many times I had to explain this concept to my clients when I worked in agencies. Most folks just don’t care. They want a link to some content they created 😄 .

Could we at least look to ditch the distinction (from a user perspective) of Post vs Page (and possibly also Custom). The other types are more complex.

@talldan
Copy link
Contributor Author

talldan commented Aug 4, 2021

This is true.

There was a related discussion here about the number of blocks in the inserter - #31584 (review).

Definitely fine to pivot on this idea to something else. I'm also supportive of removing the variations from the inserter.

@getdave
Copy link
Contributor

getdave commented Aug 4, 2021

Just realise - the reason we have variations is because we need to know the type to persist when saving in order that it will be backwards compatible with the existing Menus system.

Perhaps we can change this so that when the link is created we discern the type (or kind) from the created link rather than relying on knowing it's variation type in advance.

@jasmussen
Copy link
Contributor

Transforming from one type of menu item into another in-situ, such as transforming from a custom link block to a page link when linking to a page, would be a nice and mostly invisible tweak that could benefit things even without unifying multiple menu item type blocks. But even beyond that, we'll still probably need to scale the quick inserter better, as is suggested here. Social Links has a similar issue.

A while back I doodled this paginated version, with the 3rd item being the button to open the inserter sidebar:

Quick Inserter

It wouldn't solve how the frecency is often not what you'd expect it to be, but at least it might show all items right there.

@talldan
Copy link
Contributor Author

talldan commented Aug 5, 2021

It wouldn't solve how the frecency is often not what you'd expect it to be, but at least it might show all items right there.

Yep, I think this is going to always be a valid part of the issue, because the first time a user interacts with the nav block the blocks that are usable outside of navigation (social icons, spacer) are likely to be first in the list.

The nav block really needs link to always be first, and if the dropdown block is merged, that should probably be second.

@jasmussen
Copy link
Contributor

The nav block really needs link to always be first, and if the dropdown block is merged, that should probably be second.

Agreed. Outside of making the frecency system smart enough to do this (or removing it entirely), it seems like it'd be useful with some sort of pinning system, especially if #33775 comes to pass in a way that potentially expands the list of items drastically.

@talldan talldan changed the title Idea: consider blocks as folders of variations in the quick inserter Confusing navigation block inserter menu / block library Aug 17, 2021
@talldan
Copy link
Contributor Author

talldan commented Aug 17, 2021

I fell into a trap of being solution oriented with this issue, so I've renamed it and updated the description to also contain some of the discussed options.

@talldan
Copy link
Contributor Author

talldan commented Mar 9, 2023

I'll close this, things have changed quite a bit.

@talldan talldan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

3 participants