Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive menu label #33985

Closed
Tracked by #35521
jffng opened this issue Aug 10, 2021 · 1 comment · Fixed by #36149
Closed
Tracked by #35521

Responsive menu label #33985

jffng opened this issue Aug 10, 2021 · 1 comment · Fixed by #36149
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress

Comments

@jffng
Copy link
Contributor

jffng commented Aug 10, 2021

It would be helpful if the responsive menu had the option to display a label on its open and close buttons, for example:

Screen Shot 2021-08-03 at 12 31 54 PM

I think this is a fairly common pattern, and maybe increases the accessibility of the responsive menu.

Sorry if this is already in an issue somewhere! I couldn't find a specific discussion after searching for a bit.

What is your proposed solution?

It's simple to achieve this by styling a pseudo-element on the existing button provided by the navigation block, but this does not allow us to translate the label without doing something messy. I think having an option in the navigation block's responsive settings to set and display the label would be great.

@jffng jffng added the [Block] Navigation Affects the Navigation Block label Aug 10, 2021
@mtias
Copy link
Member

mtias commented Aug 12, 2021

I think we discussed allowing a button (with customizable text) or the icon, but not a mix. cc @jasmussen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants