Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Save as" button from Navigation block toolbar #36593

Closed
tellthemachines opened this issue Nov 18, 2021 · 3 comments · Fixed by #36760
Closed

Remove "Save as" button from Navigation block toolbar #36593

tellthemachines opened this issue Nov 18, 2021 · 3 comments · Fixed by #36760
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress

Comments

@tellthemachines
Copy link
Contributor

What problem does this address?

If a theme inserts a Navigation block as part of a template, when viewing it in the editor, a "Save as" button appears in the block toolbar, like so:

Screen Shot 2021-11-18 at 2 06 00 pm

This can be confusing for users (no other blocks have a save button), and is not strictly necessary for the navigation saving flow; any changes made to the block will be saved together with other template changes when clicking the editor "Save" button.

What is your proposed solution?

Remove the "Save as" button from the Navigation toolbar.

@tellthemachines
Copy link
Contributor Author

Closing as duplicate of #36575

@mkaz
Copy link
Member

mkaz commented Nov 18, 2021

I'm reopening this one. The other ticket #36575 was a duplicate but included two different issues with different priorities, so better to split out. Since this ticket has better details, it'll be a better one to work off.

@getdave
Copy link
Contributor

getdave commented Nov 22, 2021

I'm looking into this one but would welcome any help.

Looks like this might be addressed by #36522?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants