Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Navigation Area block #36728

Closed
adamziel opened this issue Nov 22, 2021 · 8 comments
Closed

Remove the Navigation Area block #36728

adamziel opened this issue Nov 22, 2021 · 8 comments
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@adamziel
Copy link
Contributor

After the discussion was started in #36524 and the block was soft deprecated in Gutenberg 12.0 (#36727), it's time to remove it in Gutenberg 12.2.

I attached 12.1 label to this issue, let's bump it to 12.2 once that milestone is created.

cc @noisysocks @getdave @draganescu

@adamziel adamziel added this to the Gutenberg 12.1 milestone Nov 22, 2021
@adamziel
Copy link
Contributor Author

I implemented a revert in #36604. It will probably be full of merge-conflicts by the time 12.2 is around the corner, but it could still serve as a blueprint.

@getdave
Copy link
Contributor

getdave commented Nov 22, 2021

Did the Nav Areas PHP code get merged to WP Core already? If so how do we revert that prior to 5.9?

@talldan talldan added [Block] Navigation Area [Type] Task Issues or PRs that have been broken down into an individual action to take labels Nov 23, 2021
@adamziel
Copy link
Contributor Author

cc @noisysocks who did the WP Core merge

@noisysocks
Copy link
Member

Ah, yeah, good flag. I opened a ticket: https://core.trac.wordpress.org/ticket/54506

@noisysocks
Copy link
Member

Patch to remove Navigation Areas from Core: WordPress/wordpress-develop#1944

@noisysocks
Copy link
Member

Removing this from the WP 5.9 board as there's nothing remaining to do for WP 5.9. Next step is to remove the Navigation Area block from the plugin in Gutenberg 12.2.

@youknowriad youknowriad removed this from the Gutenberg 12.1 milestone Dec 8, 2021
@talldan
Copy link
Contributor

talldan commented Sep 30, 2022

I can't see it in the codebase, so will close this.

@talldan talldan closed this as completed Sep 30, 2022
@getdave
Copy link
Contributor

getdave commented Oct 4, 2022

I removed it. Some how I forgot to cross link the issues. Thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

5 participants