Remove Navigation Area endpoints and utility functions #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why GitHub isn't letting me request a review from @getdave 🤔 |
I guess because I haven't committed here before or something? |
45 tasks
adamziel
reviewed
Nov 25, 2021
adamziel
approved these changes
Nov 25, 2021
|
I tried to testing this but my local WordPress develop setup wouldn't start up. Adam's 👍 is good enough for me. |
spacedmonkey
approved these changes
Nov 25, 2021
|
This looks good @noisysocks . Happy to commit? |
38 tasks
If you wouldn't mind committing @spacedmonkey I think we're good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the Navigation Area endpoints and utility functions from Core. In WordPress/gutenberg#36524 it was decided to remove the Navigation Area functionality form WP 5.9.
Trac ticket: https://core.trac.wordpress.org/ticket/54506
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.