Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page List: allow a maximum number option #37340

Open
annezazu opened this issue Dec 13, 2021 · 3 comments
Open

Page List: allow a maximum number option #37340

annezazu opened this issue Dec 13, 2021 · 3 comments
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

As part of the eleventh call for testing for the FSE Outreach program, feedback came in from a WP Tavern article around a desire to set a max number of pages shown:

I started by removing the Page List block from the Navigation menu in the header. I have 90+ pages on my install, and it is always irritating when themes list them all by default.

Later, in the comments, a few other folks chimed in:

At the moment the Page List, although not ideal, seems the best compromise. A small snippet of CSS could limit the displayed page list menu items, but when we want to get away from themes adding stuff like this and let core/gutenberg handle it, a maximum number option would be a great thing to have.

The Gutenberg team couldn’t be convinced to change this. Another missed opportunity for improving themes.

What is your proposed solution?

Similar to #29585 allow an option for a max number of pages shown.

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block labels Dec 13, 2021
@talldan
Copy link
Contributor

talldan commented Dec 14, 2021

For anyone looking to pick this up, this is already half implemented (the block has an __unstableMaxPages attribute), but it only affects how the block appears on the front-end and not the pages shown in the editor. There's also no way to set a value in the editor.

#36877 has more info.

@talldan
Copy link
Contributor

talldan commented Dec 14, 2021

The Gutenberg team couldn’t be convinced to change this. Another missed opportunity for improving themes.

What's the background on this? I don't think I've ever seen anyone be disparaging of feature requests for Page List as described here, but maybe I missed a conversation.

@annezazu
Copy link
Contributor Author

Thanks SO much for connecting the dots here!

What's the background on this? I don't think I've ever seen anyone be disparaging of feature requests for Page List as described here, but maybe I missed a conversation.

Ah apologies. This comment referenced this previous issue: #36721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants