Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Classic menus not listed for nav block configured by theme #37634

Closed
annezazu opened this issue Dec 27, 2021 · 7 comments
Closed
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

With WordPress 5.9 Beta 4, I tried creating a fresh site with 5.8.2, make a few menus using the prior way, and then switch to FSE. When adding the navigation block, I expected to see various "Classic" menus listed as a result but found none when trying to edit the navigation block that came with TT2. If I added a new navigation block, I could see them listed. I replicated this twice across different completely new test sites. When looking at the latest update on the nav block tracking, I don't see anything indicating that importing classic menus shouldn't work: #35521

Note that the Manage Menus section doesn't list the classic menus either (not sure what's expected there).

Step-by-step reproduction instructions

  1. Create a site with WP 5.8.2
  2. Create a few menus with a classic theme.
  3. Update to 5.9 Beta 4 and enable TT2.
  4. Open the Appearance > Editor.
  5. Try to use the "select menu" option in the header for the navigation block listed. Notice classic menus are missing.
  6. Add a brand new navigation block and see that classic menus are listed.

Screenshots, screen recording, code snippet

nav.block.-.classic.options.mov

Environment info

  • WordPres 5.9 beta 4
  • TT2
  • No Gutenberg

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Dec 27, 2021
@Mamaduka
Copy link
Member

Hi, @annezazu

Do you get different results if you use the Classic theme on 5.9 beta4 to create menus and then switch TT2?

@annezazu
Copy link
Contributor Author

No. I get the same result sadly :( I tried that yesterday too and found it still does not show unless I add a brand new navigation block to the site editor.

@Mamaduka
Copy link
Member

Thanks for the update, @annezazu. I will try to track this down tomorrow, and hopefully, we can ship the fix with 5.9.

@Mamaduka
Copy link
Member

@annezazu, I think this behavior is intentional, but I couldn't find details in PRs. @talldan or @getdave might have more information.

@annezazu
Copy link
Contributor Author

Thanks for digging in. Happy to close out if there's more context but wanted to report to be safe in case it wasn't :)

@Mamaduka
Copy link
Member

Mamaduka commented Jan 5, 2022

@annezazu, I'm going to remove this from the 5.9 board. Once we have more context, we can find the next target release, minor or major.

@annezazu
Copy link
Contributor Author

This issue matches #38166 which has been resolved ahead of a 5.9 RC4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants