Admin bar: Edit site link should open the current template #37850

carolinan · 2022-01-11T08:11:21Z

Description

Often when I use the "Edit site" link in the WordPress admin bar, it is because I want to edit the current template.
This can be a post/page or an archive (they should all work the same).

Instead, the link opens the index/home/front-page, and I have to find a way to navigate to the template I wanted to edit.

Step-by-step reproduction instructions

With a full site editing theme active:

Login.
Navigate to an archive page.
Click on the edit site link in the WordPress admin bar.
See that the home page opens, not the page you were viewing.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

alexstine · 2022-01-14T10:18:45Z

Makes sense to me. Less clicks for sure. Would make it work the same as Edit Post/Page/other post type. I would not be happy if I clicked Edit Post and got taken to the list of posts vs. the post I wanted to edit.

carolinan · 2022-04-11T07:40:15Z

Alternatively, let this menu have two links, "Edit site" and "Edit template" which would lead to the current template, either in the site editor (for site templates) or the template editor (for single post/pages).

beckej13820 · 2022-04-19T18:34:46Z

Just dropping by to add a +1. I have found myself doing a lot of clicking around going into and out of Full Site Editing. The two biggest issues are the preview button not working in FSE, and not being able to get directly back to the template I am looking at from the front end.

annezazu · 2022-07-16T21:48:05Z

This was noted in the fifteenth call for testing for the FSE Outreach Program, which has a focus on creating and editing the categories template:

After visiting the newly created categories template, I went to the Site Editor again to fix a mistake I made earlier. However, when you click on “Edit site” in the admin bar, instead of loading the template you were just on, the home page template gets loaded. It would be better if the template you’re currently on, so in this case when I hit the “Edit site” button while I’m on a category page, I’d like to be directly taken to the Category template.

& again in a separate comment:

It is a bit odd to me that the toolbar on the frontend of the site has an “edit page” option sometimes, but not for all pages. I wonder if still having an edit page, there could be an “edit template” button or something if it’s a template and not a page?

& even more in an additional comment:

It would also be nice if the Edit Site button, would bring you to the template you were currently viewing. For now it seems to always just bring you to the homepage by default, then you have to go to templates and load the template you want to edit. Would be a lot easier to have the edit site be context aware.

jameskoster · 2022-08-08T17:45:51Z

I think a single 'Edit template' link could make sense as an accompaniment to 'Edit post'. We might even combine them into a single dropdown.

Edit
- Post
- Template

One other thing to consider is when to pass context to base templates. For example if I'm viewing my 'Hello World!' post and it uses the single template, what do I see when I click 'Edit template'? If we populate the template with the post content, folks might be misled into thinking the template only serves that one post. If we don't, would the transition be too abrupt, or confusing?

bacoords · 2022-08-19T21:47:30Z

Because this is a UX pattern that we see pretty consistently in other page builders, I built a simple plugin (unaware of this open issue) to tackle this for myself. There's some holes in how we can determine the templates, so I think the final approach would require some better infrastructure to determine the active templates/template parts ( #32309 being a good example).

I'm just including a link to my repo as a functional design proof of concept. I basically added some dropdown nodes under the "Edit site" link with more specific links to the templates that are visible. So a user could still select 'Edit Site' or they could navigate to a specific template/part by selecting one of the dropdown links.

https://github.com/bacoords/site-editor-links

clubkert · 2022-08-26T15:01:51Z

I think a single 'Edit template' link could make sense as an accompaniment to 'Edit post'. We might even combine them into a single dropdown.

Edit

Post

Template

This is an interesting idea when looking to edit a template for a post.

There are also times when there would only be an option to edit the template (i.e. there is not post), like the 404 page. In the below example, if I click "edit site" it just takes me to the main site editor (not the 404 template).

carolinan · 2023-03-15T14:39:04Z

I made an attempt at this:

A new menu item needs to be added to wp_admin_bar_edit_site_menu in wp-includes/admin-bar.php.
The link needs to include the theme slug and the template slug
'href' => admin_url( 'site-editor.php?postType=wp_template&postId=' . $theme . '%2F%2F' . $template . '&canvas=edit' ),
For singles, it is possible to get the custom page template slug from the _wp_page_template post meta.
Basic templates in the template hierarchy needed to be checked with is_404, is_search and so on. This created a long list of if statements which doesn't seem like the best solution.
This leaves how to get the correct template slug for single archives, single terms, etc.
Getting the slug for custom post types was untested.
And what if the page is the search results, but a template for it has not been created? There needs to be checks in place.

porg · 2023-06-14T22:15:15Z

@annezazu and @getdave — Continuing here as you recommended.

@carolinan — The essence of my issue #49438 was a duplicate of this your very issue here.

Mine has some graphics with a user story. Please feel free to copy it into your issue text on top (to aid quick understanding & attention).

@ALL

How can we get this issue moving?
- Is there a corresponding WordPress Core ticket already?
- If so please link it (also in issue text).
Seemingly low hanging fruit to support Optimise the content-centric edit experience in the Site Editor #49404
- This should be made clear between team Gutenberg and Core in regards to prioritization.

paaljoachim · 2023-06-15T07:35:08Z

It is really good to see this issue being worked on! I have met the same thing as well. Clicking Edit Site only goes to the Front Page Template. I expected it to open the template related to the page that I am on.

getdave · 2023-06-15T08:56:22Z

It's my understanding that this would eventually require a Core patch for the Edit link in the admin bar. It would also require that all the routes in the Site Editor are stable as public APIs (I'm not sure whether this is the case yet).

I could not personally commit to working on this feature at this point in the release cycle. However, it is open for contributions should anyone like to take a look.

The work @bacoords did in his Plugin looks like a good starting point. It could land initially in Gutenberg via the hooks API and thus won't need a Core patch.

priethor · 2023-06-27T17:00:03Z

Opening the current template is the only logical outcome and what most users might expect. We should address this malfunction sooner rather than later.

skorasaurus · 2023-06-27T18:38:46Z

If this is resolved; there probably should be a hook exposed so that developers can obtain what template(s) are currently being rendered; solving #32309

porg · 2023-06-27T20:40:42Z

@carolinan — Please copy my graphics from #49438 to your issue description on top.

If we link this very Gutenberg issue here in a corresponding WordPress Core Issue, visuals likely aid exposure.

Mamaduka · 2023-07-07T07:28:05Z

I just created a core PR for this enhancement.

Links

@porg, do you mind attaching your visual aid graphs to the core ticket - https://core.trac.wordpress.org/ticket/58746?

porg · 2023-07-07T09:16:59Z

@Mamaduka

Very glad that someone picked this low hanging UX improvement fruit eventually!
I attached the graphic to the linked WP Core ticket.

@carolinan and everyone

Feel free to copy the graphic it to where-ever it helps! (on top of this very issue here too ofc).

…emplate. Adds a global, `$_wp_current_template_id`, to allow the 'Edit site' link in the admin bar to be aware of the current template and pass it to the Site Editor, so it can load the appropriate one directly. See WordPress/gutenberg#37850 for further discussion. Props Mamaduka, poena, abitofmind, audrasjb, mikinc860, alexstine, annezazu, beckej, jameskoster, bacoords, clubkert, paaljoachim, get_dave, priethor, skorasaurus. Fixes #58746. git-svn-id: https://develop.svn.wordpress.org/trunk@56209 602fd350-edb4-49c9-b593-d223f7449a82

…emplate. Adds a global, `$_wp_current_template_id`, to allow the 'Edit site' link in the admin bar to be aware of the current template and pass it to the Site Editor, so it can load the appropriate one directly. See WordPress/gutenberg#37850 for further discussion. Props Mamaduka, poena, abitofmind, audrasjb, mikinc860, alexstine, annezazu, beckej, jameskoster, bacoords, clubkert, paaljoachim, get_dave, priethor, skorasaurus. Fixes #58746. Built from https://develop.svn.wordpress.org/trunk@56209 git-svn-id: http://core.svn.wordpress.org/trunk@55721 1a063a9b-81f0-0310-95a4-ce76da25c4cd

getsource · 2023-07-11T11:44:47Z

Thanks so much everyone!

I'm going to close this, as it should be fixed in this commit:
https://core.trac.wordpress.org/changeset/56209

If you notice this is not the case, please feel free to reopen!

…emplate. Adds a global, `$_wp_current_template_id`, to allow the 'Edit site' link in the admin bar to be aware of the current template and pass it to the Site Editor, so it can load the appropriate one directly. See WordPress/gutenberg#37850 for further discussion. Props Mamaduka, poena, abitofmind, audrasjb, mikinc860, alexstine, annezazu, beckej, jameskoster, bacoords, clubkert, paaljoachim, get_dave, priethor, skorasaurus. Fixes #58746. Built from https://develop.svn.wordpress.org/trunk@56209 git-svn-id: https://core.svn.wordpress.org/trunk@55721 1a063a9b-81f0-0310-95a4-ce76da25c4cd

autumnfjeld · 2023-07-25T01:12:54Z

For clarity, just confirming this the wordpress admin bar, yes?

annezazu · 2023-07-25T01:17:12Z

Yes. What you are showing appears to be something related to WordPress.com and not WordPress Core functionality.

carolinan added the [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable label Jan 11, 2022

carolinan mentioned this issue Feb 17, 2022

Edit Site button should open the Site Editor with the current template open #38885

Closed

Mamaduka closed this as completed Apr 11, 2022

Mamaduka reopened this Apr 11, 2022

Mamaduka mentioned this issue Apr 11, 2022

Edit Site should edit the template for the current page #40211

Closed

annezazu added the Needs Design Feedback Needs general design feedback. label Apr 19, 2022

carolinan self-assigned this Mar 15, 2023

annezazu mentioned this issue Apr 5, 2023

Site Editor shall know from which ID it got invoked and initiate with that page/post content and the underlaying template #49438

Closed

priethor added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Priority] High Used to indicate top priority items that need quick attention labels Jun 27, 2023

priethor added this to Polish Jun 27, 2023

priethor moved this to Needs development in Polish Jun 27, 2023

priethor added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Jun 27, 2023

annezazu added this to WordPress 6.3.x Editor Tasks Jul 4, 2023

annezazu moved this to 📥 Todo in WordPress 6.3.x Editor Tasks Jul 4, 2023

annezazu mentioned this issue Jul 4, 2023

Add option to Edit Template directly while viewing front end of site #32048

Closed

Mamaduka mentioned this issue Jul 7, 2023

Toolbar: Make the 'Edit site' link aware of the current template WordPress/wordpress-develop#4810

Closed

priethor added [Status] In Progress Tracking issues with work in progress and removed Needs Dev Ready for, and needs developer efforts labels Jul 7, 2023

priethor moved this from Needs development to Needs review in Polish Jul 7, 2023

priethor moved this from 📥 Todo to 🔎 Needs Review in WordPress 6.3.x Editor Tasks Jul 7, 2023

priethor assigned Mamaduka Jul 7, 2023

priethor changed the title ~~Feature request: Admin bar: Edit site link should open the current template~~ Admin bar: Edit site link should open the current template Jul 7, 2023

getsource closed this as completed Jul 11, 2023

github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.3.x Editor Tasks Jul 11, 2023

priethor moved this from Needs review to Done in Polish Jul 11, 2023

priethor removed the [Status] In Progress Tracking issues with work in progress label Aug 16, 2023

Mamaduka mentioned this issue Jul 23, 2024

Update the “Edit site” admin bar control to open the Site Editor at the top-level, consistently #63785

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Admin bar: Edit site link should open the current template #37850

Admin bar: Edit site link should open the current template #37850

carolinan commented Jan 11, 2022

alexstine commented Jan 14, 2022

carolinan commented Apr 11, 2022

beckej13820 commented Apr 19, 2022 •

edited

Loading

annezazu commented Jul 16, 2022 •

edited

Loading

jameskoster commented Aug 8, 2022 •

edited

Loading

bacoords commented Aug 19, 2022

clubkert commented Aug 26, 2022

carolinan commented Mar 15, 2023 •

edited

Loading

porg commented Jun 14, 2023 •

edited

Loading

paaljoachim commented Jun 15, 2023

getdave commented Jun 15, 2023

priethor commented Jun 27, 2023

skorasaurus commented Jun 27, 2023

porg commented Jun 27, 2023

Mamaduka commented Jul 7, 2023

porg commented Jul 7, 2023

getsource commented Jul 11, 2023

autumnfjeld commented Jul 25, 2023

annezazu commented Jul 25, 2023

Admin bar: Edit site link should open the current template #37850

Admin bar: Edit site link should open the current template #37850

Comments

carolinan commented Jan 11, 2022

Description

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

Environment info

Please confirm that you have searched existing issues in the repo.

Please confirm that you have tested with all plugins deactivated except Gutenberg.

alexstine commented Jan 14, 2022

carolinan commented Apr 11, 2022

beckej13820 commented Apr 19, 2022 • edited Loading

annezazu commented Jul 16, 2022 • edited Loading

jameskoster commented Aug 8, 2022 • edited Loading

bacoords commented Aug 19, 2022

clubkert commented Aug 26, 2022

carolinan commented Mar 15, 2023 • edited Loading

porg commented Jun 14, 2023 • edited Loading

paaljoachim commented Jun 15, 2023

getdave commented Jun 15, 2023

priethor commented Jun 27, 2023

skorasaurus commented Jun 27, 2023

porg commented Jun 27, 2023

Mamaduka commented Jul 7, 2023

porg commented Jul 7, 2023

getsource commented Jul 11, 2023

autumnfjeld commented Jul 25, 2023

annezazu commented Jul 25, 2023

beckej13820 commented Apr 19, 2022 •

edited

Loading

annezazu commented Jul 16, 2022 •

edited

Loading

jameskoster commented Aug 8, 2022 •

edited

Loading

carolinan commented Mar 15, 2023 •

edited

Loading

porg commented Jun 14, 2023 •

edited

Loading