Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline headings don't work when we preview tablet or mobile in classic and hybrid themes #48189

Closed
ntsekouras opened this issue Feb 17, 2023 · 1 comment
Closed

Outline headings don't work when we preview tablet or mobile in classic and hybrid themes #48189

ntsekouras opened this issue Feb 17, 2023 · 1 comment
Labels
[Feature] Document Outline An option that outlines content based on a title and headings used in the post/page [Type] Bug An existing feature does not function as intended

Comments

@ntsekouras
Copy link
Contributor

In a different PR that was trying to fix the title link in outline, @t-hamano observed:

I have found that in the non-iframe editor when I switch to preview, the anchor no longer works because the ID of the title changes. Can we give a fixed id to the post title? Or is there a way to keep the instanceID?

23284ea2283a9fb9c67a7b22ffad60cd.mp4

This seems to be the case for every block in classic and hybrid themes as well, since when we iframed the previews. In these themes we don't iframe initially(desktop) but then iframe the previews resulting in different blockIds.

Related: #47624
@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Feature] Document Outline An option that outlines content based on a title and headings used in the post/page labels Feb 17, 2023
@ntsekouras ntsekouras mentioned this issue Feb 17, 2023
Closed
@ellatrix
Copy link
Member

This has been fixed since we're using the iframe for the post editor too (same editor as previews)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Document Outline An option that outlines content based on a title and headings used in the post/page [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ellatrix @ntsekouras