[Editor]: Handle title display and selection in outline
#48124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +65 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 564ed10. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4192954208
|
|
Thank you for the PR! I have found that in the non-iframe editor when I switch to preview, the anchor no longer works because the ID of the title changes. Can we give a fixed id to the post title? Or is there a way to keep the instanceID? 23284ea2283a9fb9c67a7b22ffad60cd.mp4 |
ellatrix
reviewed
Feb 16, 2023
| const titleNode = document.querySelector( '.editor-post-title__input' ); | ||
| const titleNode = | ||
| document.querySelector( '.editor-post-title__input' ) || | ||
| window.frames[ 'editor-canvas' ]?.document.querySelector( |
There was a problem hiding this comment.
I really don't like this. :) Could we call onSelect for the PostTitle, which is in this package? I guess we'd have to move the local state to the package store first.
There was a problem hiding this comment.
What do you mean by state? And which part exactly you don't like? I mean querying for nodes is bad, but I don't think I deviated here from the existing document.querySelector( '.editor-post-title__input' ). 😄
There was a problem hiding this comment.
My understanding is that state is the isSelected that the PostTitle component has. This would mean that the code would be something like the following? 🤔
const { selectPostTitle } = useDispatch( editorStore );
const isPostTypeSelected = useSelect(
( select ) => {
return select( editorStore ).isPostTitleSelected();
},
[]
);If so, I think the problem with #48189 may be resolved.
@t-hamano that seems to be the case for every block in classic and hybrid themes as well, since when we iframed the previews. In these themes we don't iframe initially(desktop) but then iframe the previews resulting in different Opened a new issue about this: #48189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #47624
If the editor content is an iframe, the title area will not be displayed. And if the post editor is not iframed, the title is not selected when we click it.
Testing Instructions
outlineclick the title and should be selected