-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Block styles are impacting several other blocks in editor and live site #50486
Comments
Thanks for sharing! I think one is pretty much related to what's also happening with the paragraph block styles. The list block is not using a |
I ran into this issue as well and ended up using custom CSS as a workaround to remove extra padding added to the Navigation block. |
I used the following CSS to address this, until the bug can be fixed:
|
I've also run into a similar issue. In my case I've set the font-size for the navigation in theme.json. On pages with the list block present however, inline CSS belonging to that block overrides the font-size for the navigation. |
I've also run into this issue. In my case, list elements with a background colour had an unexpected style when I set paddings to the list block because of this CSS added to it. The target seems to be too broad.
Steps to reproduce this.
|
Just saw another unwanted effect in the editor caused by these "too-broad" selectors from Global Styles. Once you change the horizontal padding for the list block, the post template that uses list item breaks. Notice the misalignment of the posts. They should remain unchanged by changing the padding change in the list block. |
Just noting that we're seeing mentions of this in the Support Forums as well. |
Another report of this here: https://wordpress.com/forums/topic/navigation-menu-appearance-varies/?view=all#post-3989938 |
@ellatrix flagging this for you. |
This caused issues on the Showcase site, and we worked around it by removing the background from the navigation block. |
Styles related to `ul.has-background` are adding unwanted padding and increasing the height of the header. Other sites only change the background color of the overlay and don't have the issue, so replicating that here.
Another report in the forums: |
After a review by core editor triage leads and core editor tech leads, this has been removed from the board for 6.5 consideration. |
@annezazu did we forget to remove this from the board, or was there a reason we did not, and do you mind providing it please? |
Hah! This should have been removed. I bet I was moving too fast. Done. |
Not sure what I can do here. This was introduced in #21387 by @ZebulanStanphill. @ZebulanStanphill, could we change this to use a class? I think it's not right that we're using a tag selector only. |
Now that the list has a class name (#56469) can the style.scss be edited to fix the issue mentioned in @iamtakashi comment? EDIT: I spoke too soon, sorry. The change to lower the specificity has already been put in place. |
@carolinan Was this fixed in #56469? |
yes, thank you for the reminder. I can confirm that this is solved. (I am using WP 6.6-RC3-58711) |
Description
There have been several reports floating around trying to describe this, but more keep arising, so I'm hoping this report can help centralize the issue a bit. In short:
The List Block's default styles and added Global Styles are also applying to other blocks in both the editor and the live site. On the live site, the symptoms present when a post contains a List block, but the editor shows symptoms even without the list block present.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Global Styles > Blocks > List Block > Text Color impacts blocks in editor
listblockstyles-part1-compressed.mp4
Text Color - Impacted blocks in editor:
Text Color - Impacted blocks in live site:
Adding List Block to template brings those symptoms and more to the live site
listblockstyles-part2-compressed.mp4
Text Color - Impacted blocks in editor:
Text Color - Impacted blocks in live site:
List block impacting the padding of the submenu (#49445)
listblockstyles-part3.mov
Padding - Impacted blocks in editor:
Padding - Impacted blocks in live site:
Adding a Background color to Global Styles > Blocks > List Block
listblockstyles-part4.mov
BG Color - Impacted blocks in editor:
BG Color - Impacted blocks in live site:
Removing the List block from the template removes all symptoms from live site
listblockstyles-part5.mov
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: