Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md file for use-setting component #52079

Closed
mburridge opened this issue Jun 28, 2023 · 7 comments · Fixed by #53162
Closed

Add README.md file for use-setting component #52079

mburridge opened this issue Jun 28, 2023 · 7 comments · Fixed by #53162
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers

Comments

@mburridge
Copy link
Contributor

What problem does this address?

The use-setting component is missing a README.md file. As per #22891

What is your proposed solution?

Pinging original creator of this component @youknowriad . and other recent committers @andrewserong and @ingeniumed, if you have the bandwidth could you add a README.md file for this component. Thank you.

This README is a good example to follow.

Please let me know if there's anything I can do to help with the creation of the README.md file for this component.

@ingeniumed
Copy link
Contributor

Thanks for bringing this up! I'm hoping to devote some time to this, this week or next week and get a PR up quickly to address it 👍🏾

@ingeniumed
Copy link
Contributor

I have put up #53162 to address this. Hopefully everything in there is sufficient to close off this issue.

@mburridge
Copy link
Contributor Author

Thanks for creating the readme.md @ingeniumed. I've approved your PR.

@ingeniumed
Copy link
Contributor

Thanks for approving it @mburridge! You are good to merge it as well, as I don't have the permission to do that.

@mburridge
Copy link
Contributor Author

Thanks for approving it @mburridge! You are good to merge it as well, as I don't have the permission to do that.

Done! Great job @ingeniumed 🙌

@ingeniumed
Copy link
Contributor

@mburridge Just mentioning it here for posterity - I think the PR got closed instead of being merged. Would be able to re-open and merge it in?

@mburridge
Copy link
Contributor Author

Looks like it's been merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants