Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add READMEs to all block-editor components #22891

Open
youknowriad opened this issue Jun 4, 2020 · 15 comments
Open

Add READMEs to all block-editor components #22891

youknowriad opened this issue Jun 4, 2020 · 15 comments
Assignees
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Developer Documentation Documentation for developers [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@youknowriad
Copy link
Contributor

The Block Editor package in Gutenberg is full of components used to build blocks or block editors. These components lack documentation.

This issue is a tracking issue for the documentation effort to add READMEs to all these components.

If you want to help with this:

  • Grab a component in the block-editor package that lacks a README
  • Comment on the issue that you want to help document this component
  • Write a README.md file for this component following the same format as the already documented components.
@youknowriad youknowriad added [Type] Developer Documentation Documentation for developers [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jun 4, 2020
@alita-moore
Copy link
Contributor

alita-moore commented Jun 13, 2020

I want to make a README for the block-alignment-matrix-toolbar, issue #22516 ; How should I proceed? Is this a README for the issue or for the component?

@youknowriad
Copy link
Contributor Author

@alita-moore yes, a README is needed for that component. so you should add a file to the component folder name it README.md, copy some existing component README to get the "base template" and fill it.

@alita-moore
Copy link
Contributor

Okay,

This README

Doesn't have a very defined structure. Are you saying to copy the format in terms of linking to the parent directory?

@youknowriad
Copy link
Contributor Author

Yes, this is not the best example. This might work better https://github.com/WordPress/gutenberg/blob/master/packages/components/src/button/README.md

@alita-moore
Copy link
Contributor

Oh okay, that's much better.

Thank you for info, I'll get cracking 👩‍💻

@JustinyAhin
Copy link
Member

Working on a pull for BlockBreadcrumb componenent https://github.com/WordPress/gutenberg/tree/master/packages/block-editor/src/components/block-breadcrumb

@JustinyAhin
Copy link
Member

I've identified all the packages that haven't yet a README.

@JustinyAhin

This comment has been minimized.

@talldan
Copy link
Contributor

talldan commented Jun 29, 2023

Just thought I'd mention that I have a few months of leave coming up, so won't be able to work on these for a while. I notice I was assigned a few.

@mburridge
Copy link
Contributor

Hi @talldan, please feel free to re-assign those to someone else that you deem has the technical knowledge required to create the readme. Thanks.

@t-hamano
Copy link
Contributor

If someone works on this issue, in addition to adding a README file, it would be great if we could also add JSDoc.
The block editor package reference is generated with a JSDoc reference for each component. Components that don't have JSDoc will look like this in the reference:

Image

The recommended complete JSDoc format should look like this:

/**
 * Component description here.
 *
 * @see https://github.com/WordPress/gutenberg/blob/HEAD/packages/block-editor/src/components/my-component/README.md
 *
 * @example
 * ```jsx
 * function MyComponent() {
 *   return (
 *     <MyComponent />
 *    );
 * }
 * ```
 *
 * @param {Object}  props        Component props.
 * @param {string}  props.prop1  props description here.
 * @param {Array}   props.prop2  props description here.
 * @return {Element} My component control.
 */
export default function MyComponent( {
	prop1,
	prop2,
} ) {
	return (
		<div>
			My Component
		</div>
	);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Developer Documentation Documentation for developers [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

10 participants