-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Book: Iterate on presentation and design #53431
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Thanks to beautiful work by @beafialho, I've updated this issue with designs attached. There's a lot to dive into, you can explore the linked Figma, but for now the main focus has been on updating the book itself, what's inside the frame. Especially on that, please share your thoughts. CC: @WordPress/gutenberg-design |
I've been looking into these designs and I have a few questions and thoughts:
How are we going to define which blocks comprise this list?
How and where are we going to define this hierarchy? Blocks in the styles book are currently rendered in the order in which they are registered, if I'm not mistaken.
This might be an answer to the first question; we could add a subcategory which the Landing Page compiles blocks from. The
Demo content is mostly the placeholders for each block, currently. I think we could be taking further advantage of the |
Thank you for looking, @vcanales!
We'd manually curate this list according to the suggestions in the mockups.
Essentially we only need a few of the blocks to be "prioritized" in a particular order, and after those, anything else can show up.
The landing page should specifically have a goal of giving you a sense of the site design. To that end, this can be thought of more like a highly curated and stylized "style card", like this: It wouldn't need to be updated that often, in part because we don't often add new blocks, in part also because it is intentially a subset. If you want to see all the blocks, you have to dive into the tabs.
This is likely fine to separate out exactly as you suggest, and not make part of this particular task. We definitely need to enrich the demo content across the board, update the current preview images, etc. |
Nice! Thanks for cross-linking that work. I can work with reasonably little detail initially - I think it's a good opportunity to set the style book up for flexibility. By that I mean, create a component that can consume some sort of map or config, which folks can tweak to determine categories/blocks etc. And then concentrate more on the content. That's the theory anyway 😄 |
@ramonjd I'm currently seeing "Custom Link" under the Design tab: |
Are you thinking of including this config in the block.json definition? A not-so-flexible approach I thought of was adding a |
It's the navigation link block, isn't it?
|
@vcanales Thanks for the suggestion. I had the same thought, but wasn't sure if it warranted updating the block.json schema (and every block.json file) just yet when things could be hard-coded for the first iteration. I hadn't seen your PR yet however, and I think it's a good idea to allow deeper categorization in general, for example, to make things more discoverable and sortable. I haven't looked closely yet, but do you think some of the existing Core filters and other functionality would also need to be aware of sub-categories?
Oh yeah, thanks for pointing that out 🤦🏻 Custom link doesn't really mean much out of context, at least to me. |
We could get away with adding them incrementally; I think a potential subcategory attribute should remain optional.
Yes, in my proposal for the schema, subcategories would be children of an existing category, so we'd have to add this awareness.
Agreed. I don't think the block's title describes it in a way that makes it easy to find. |
Related: Proposed also a "typography" tab. |
This commit creates a static category map based on list defined in Style Book: Iterate on presentation and design. #53431. It also: - Sorts examples based on static categories and their subcategories - Introduces simple layout for subcategories (under theme) - Adds unit tests for utils - Converts utils to TypeScript Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: vcanales <[email protected]> Co-authored-by: jasmussen <[email protected]>
This commit creates a static category map based on list defined in Style Book: Iterate on presentation and design. WordPress#53431. It also: - Sorts examples based on static categories and their subcategories - Introduces simple layout for subcategories (under theme) - Adds unit tests for utils - Converts utils to TypeScript Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: vcanales <[email protected]> Co-authored-by: jasmussen <[email protected]>
Update: work is underway on this one so I've updated this to "In Progress" from "Needs Dev". A couple of the PRs for this that have landed so far include: Here's how the Colors tab is looking on 2024-10-25.14.15.33.mp4Also, discussion is happening over in #66376 on where the Styles screen (and therefore Style Book) will live in the future. |
I attached a sub issue for the landing page: However given the following:
I don't really understand the case for implementing it yet. My current impression is that we won't know until the dedicated style screen is defined. There are several open questions, namely:
|
Working with @tellthemachines and @matiasbenedetto on #67541, #67546 and #66545, and especially #65619, it's become clear that a few aspects of the initial issue here are now slightly out of date, and can benefit from some clarity. So I worked to add some clarity in this Figma, to outline new categories that work well with Styles in the site view of the site editor. Mockup: A few changes here, including some small tweaks to make spacings and metrics unified. Two heading styles: major heading (16px font size) and subheading (13px font size): Color swatch size has been clarified. On the landing page, they are small, 4 columns, 32px height: On the Colors drilldown page, they are 2 colummns and bigger (52px, should that be 64? CC: @WordPress/gutenberg-design ): Speaking of drilldowns, in order for the style book to be contextual to Global Style sections (Typography, Colors, Background, Shadows, Layout, Blocks, and individual blocks), the categories initially outlined here I've revisited. Tentatively, with this suggestion: Main Styles section: show the Landing category: Styles → Typography: Show the Typography category: Styles → Colors: show the Colors category: Styles → Blocks: Show all remaining Style book categories in one long list, subdivided by headings: That absorbs categories Site Identity, Design, Posts, Media, Widgets, and any sections plugins add. Styles → Blocks → Button: Show just the Buton block: Styles → Blocks → Navigation: Here are some more contextual examples: |
Brief
The main goal of this refresh is to better organize the blocks that make up your site into a representation of the book of style for your site. Organize into what could have been a design manual. This work includes:
Requirements
Visual
Landing page
The landing page would be useful for the current iteration of the Site View, which does not currently feature tabs. It serves as a quick glanceable "poster view" for the site style guide:
Finally it would serve to have deep-links to the other tabs, e.g. clicking "Headings" would take you to the Text tab:
Reorganizing blocks
To afford this structure, the new categories, Color and Theme would benefit orientation. Here is a suggestion how we could reorganize existing blocks, as well as include all the site-specific blocks in those taxonomies:
Designs in this issue are created by @beafialho. Figma.
The text was updated successfully, but these errors were encountered: