Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize inputs styling and consider to darken the border color #5482

Closed
afercia opened this issue Mar 7, 2018 · 2 comments
Closed

Standardize inputs styling and consider to darken the border color #5482

afercia opened this issue Mar 7, 2018 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Mar 7, 2018

Comparing inputs (checkboxes, input, textarea, select) in the Gutenberg UI, they don't always use the same styling.

Checkboxes in the meta box area and in the sidebar:

screen shot 2018-03-07 at 17 54 28

In the meta box area, they have rounded corners and the border color is a very light #e2e4e7 ($light-gray-500). In rhe sidebar, they have square corners and the border color is a slightly darker #b4b9be

Not sure why all the input, select, and textarea elements in the meta box area should have rounded corners. From an a11y perspective that's a minor issue, I guess that's more of interest from a design perspective. I'd rather recommend to darken the borders as they very very light.

Textarea in the sidebar:

Inherits the border color from WordPress forms.css and the color is a gray #ddd. I guess there should be some consistency and all the inputs, textarea, selects, should always use the same border color. It would be great to use the same scss variable for all of them.

I wouldn't recommend to go for anything lighter than the colors currently used in WordPress. Worth also noting the border color should be even a bit darker, since in WordPress the actual contrast for form fields is helped by the fact the background is almost always gray.

Currently, the overall contrast of the form fields is lower than in WordPress. I'd hope for a contrast that is, at least, equivalent.

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. labels Mar 7, 2018
@karmatosed
Copy link
Member

👍 to unify the color and the darker works.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Mar 7, 2018
@paulwilde
Copy link
Contributor

See also #4963.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

3 participants