Remove meta boxes area inputs styles. #5561
Conversation
|
I tend to agree with the reasoning here, and given that removing the override styles simplifies the code, I think that aspect makes sense too. Overriding CSS in general, no matter the intent, is a form of technical debt, so thumbs up to that. Just to get a sanity check, adding Gutenberg-Core for review, though. |
|
|
||
| .edit-post-meta-boxes-area__clear { | ||
| clear: both; | ||
| &__clear { |
There was a problem hiding this comment.
FWIW I found the previous form, with independent selector, to be more readable. I tend to avoid & except for applying modifiers (&.is-empty, &:disabled)
There was a problem hiding this comment.
No strong preferences. I tend to put everything inside a block when there's a prefix to use. Will resolve conflicts and wait.
|
Needs conflicts resolved before merge. |
|
And maybe also wait an hour until 2.4 is released. |
This PR tries to make sure the styles of the content added by plugins in the meta boxes area stay unchanged.
I'd propose to consider content in the meta boxes area as "legacy content": plugins already style their content based on the current WordPress styles and they shouldn't be forced to adapt because Gutenberg provides new styles.
Specifically, this PR removes all styles applied to input (all inputs), select, and textarea elements allowing them to inherit from the WP styles. Note: also removes a rule for a
#postelement that is not used any longer (it was a form element in previous meta boes area implementation).Example before:
After:
Worth noting the meta boxes area below the post is really "legacy" since plugins are strongly encouraged to integrate following the new Gutenberg patterns (Sidebar API etc.).
Fixes #5482.