Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All colors should use variables #572

Closed
afercia opened this issue Apr 29, 2017 · 1 comment · Fixed by #581 · May be fixed by makbarGroup/gutenberg#3 or monzerfoda/gutenberg#2
Closed

All colors should use variables #572

afercia opened this issue Apr 29, 2017 · 1 comment · Fixed by #581 · May be fixed by makbarGroup/gutenberg#3 or monzerfoda/gutenberg#2
Assignees
@jasmussen

Comments

@afercia
Copy link
Contributor

afercia commented Apr 29, 2017

See for example:

gutenberg/editor/assets/stylesheets/main.scss

Line 2 in e622a12

background: #fff;

gutenberg/editor/components/block-switcher/style.scss

Line 41 in e622a12

background: #fff;

gutenberg/editor/components/inserter/style.scss

Line 28 in e622a12

color: #00aadc;

gutenberg/editor/components/inserter/style.scss

Line 38 in e622a12

background: #fff;

@afercia
Copy link
Contributor Author

afercia commented Apr 29, 2017

Wondering it also all the rgba ones should use variables or the Sass rgba().

@jasmussen jasmussen self-assigned this May 1, 2017
jasmussen added a commit that referenced this issue May 1, 2017
@jasmussen
Replace all colors with variables.
02c5737 
Fixes #572.
@jasmussen jasmussen mentioned this issue May 1, 2017
Merged
@snyk-bot snyk-bot mentioned this issue Apr 15, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jun 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jasmussen @afercia