Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages data view: Update title field so that homepage and posts page are marked with a badge #57763

Closed
jameskoster opened this issue Jan 11, 2024 · 6 comments · Fixed by #61718
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

In wp-admin this is achieved with a text label:

Screenshot 2024-01-11 at 14 21 48

In the current pages list the homepage and posts page appear at the top with icons to denote their purpose:

Screenshot 2024-01-11 at 14 22 22

In the pages data view there is no indication at all about which page serves as the homepage / posts page. Lets come up with a design to achieve this.


There are other situations where such a pattern can be useful – for instance the privacy policy page in core, and the shop / cart / checkout pages are also marked this way – so it could be worth implementing this in a reusable/extendable fashion.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Jan 11, 2024
@jameskoster jameskoster added the Needs Design Needs design efforts. label Jan 12, 2024
@jameskoster
Copy link
Contributor Author

Accounting for the different layouts I think the safest initial approach here may be to add a text label:

page marking

@youknowriad
Copy link
Contributor

Is this the same "badge" kind of fields that we have in "patterns" for the sync status? Because the design looks different to me in the mockups.

@jasmussen jasmussen moved this from Next to In Dev in Design priorities May 15, 2024
@jasmussen jasmussen moved this from In Dev to Needs Dev in Design priorities May 15, 2024
@jameskoster
Copy link
Contributor Author

It depends whether this data is a field, technically speaking. I could be convinced otherwise, but I didn't see it as one for a couple of reasons;

  1. There can only be one home / posts page
  2. I don't know that you'd ever sort / filter by 'is home page'
  3. It doesn't feel like a field you'd ever toggle off, and given all pages except one would be false, it seems a waste of space in the table.

My feeling was that it should be a badge, appended to the title field. Ideally we graduate the badge to a component for consistent display, but that can happen later.

@youknowriad
Copy link
Contributor

Ok, so you're saying that this is just a different rendering for the "title" field. That could work.

@jameskoster jameskoster changed the title Pages data view: mark homepage and posts page Pages data view: Update title field so that homepage and posts page are marked with a badge May 15, 2024
@oandregal oandregal self-assigned this May 16, 2024
@oandregal
Copy link
Member

Going to give this one a quick shot.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 16, 2024
@oandregal
Copy link
Member

PR at #61718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants