Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a link to an image does not work, the input disappears #5894

Closed
paulwilde opened this issue Mar 29, 2018 · 2 comments · Fixed by #5942
Closed

Adding a link to an image does not work, the input disappears #5894

paulwilde opened this issue Mar 29, 2018 · 2 comments · Fixed by #5942
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@paulwilde
Copy link
Contributor

When you begin typing anything in the image link input, it simply just closes the UI.

screen shot 2018-03-30 at 00 34 52
@paulwilde paulwilde changed the title Add a link to an image does not work, the input disappears Adding a link to an image does not work, the input disappears Mar 29, 2018
@Soean Soean added the [Type] Bug An existing feature does not function as intended label Mar 30, 2018
@bph
Copy link
Contributor

bph commented Mar 30, 2018

@paulwilde thanks for writing this up. In addition, if there is a link associated with a pre 2.5 image block, you are not able to change it, except via the HTML editor of the block. And it saves.

@faishal faishal mentioned this issue Apr 3, 2018
Merged
3 tasks
@faishal
Copy link
Contributor

faishal commented Apr 3, 2018

I have pushed the fix in #5842

While working on it, I found noticed following things

@danielbachhuber danielbachhuber added the [Feature] Blocks Overall functionality of blocks label Apr 10, 2018
youknowriad pushed a commit to faishal/gutenberg that referenced this issue Apr 18, 2018
@faishal @youknowriad
WordPress#5894:Image add link input disappear when start typing, fixe…
72bb5c6 
…d it by stopping event propagation

Signed-off-by: Faishal Saiyed <[email protected]>
youknowriad pushed a commit that referenced this issue Apr 18, 2018
@faishal @youknowriad
Fixed image add link input disappears issue (#5942)
7e25ca2 
* #5894:Image add link input disappear when start typing, fixed it by stopping event propagation

Signed-off-by: Faishal Saiyed <[email protected]>

* Fix issues with suggestions not working in image block

The issue was that on mobile, the block toolbar has overflow auto so as to scroll horizontally. This hid the suggestions box in a weird scrollbar.

This PR tweaks that, so the suggestions don't show up on mobile at all. This is not an ideal fix, but suggestions weren't very mobile friendly in the first place.

Suggest we get this in now as a bandaid, and then look at addressing suggestions on mobile separately, for example using the same technique the block switcher uses.

* Fix issue with caption links

* Ignore typing in block toolbars
@aduth aduth mentioned this issue Apr 18, 2018
Merged
nuzzio pushed a commit to nuzzio/gutenberg that referenced this issue Apr 25, 2018
@faishal @nuzzio
Fixed image add link input disappears issue (WordPress#5942)
5ef14c1 
* WordPress#5894:Image add link input disappear when start typing, fixed it by stopping event propagation

Signed-off-by: Faishal Saiyed <[email protected]>

* Fix issues with suggestions not working in image block

The issue was that on mobile, the block toolbar has overflow auto so as to scroll horizontally. This hid the suggestions box in a weird scrollbar.

This PR tweaks that, so the suggestions don't show up on mobile at all. This is not an ideal fix, but suggestions weren't very mobile friendly in the first place.

Suggest we get this in now as a bandaid, and then look at addressing suggestions on mobile separately, for example using the same technique the block switcher uses.

* Fix issue with caption links

* Ignore typing in block toolbars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed image add link input disappears issue faishal/gutenberg
5 participants
@danielbachhuber @bph @Soean @paulwilde @faishal