Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataForm: replicate DocumentInspector in QuickEdit #64519

Closed
11 tasks done
gigitux opened this issue Aug 14, 2024 · 9 comments
Closed
11 tasks done

DataForm: replicate DocumentInspector in QuickEdit #64519

gigitux opened this issue Aug 14, 2024 · 9 comments
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Experimental Experimental feature or API.

Comments

@gigitux
Copy link
Contributor

gigitux commented Aug 14, 2024

In the Site Editor, the Pages page is powered by the DataViews library. We are implementing the Detail Panel (aka Quick Edit) to allow users to edit one or more pages easily (#55101). This issue contains a list of the view/edit controls that we have to implement for this view:

@youknowriad youknowriad added the [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond label Aug 14, 2024
@louwie17
Copy link
Contributor

We may also want to add password, date, and allow comments to this list.
Although looks like date is already implemented: #64267

In addition the posts quick edit has Categories, and Tags as well.

@gigitux
Copy link
Contributor Author

gigitux commented Aug 22, 2024

We may also want to add password, date, and allow comments to this list.
Although looks like date is already implemented: #64267

Thanks! Added!

In addition the posts quick edit has Categories, and Tags as well.

True, but Categories and Tags doesn't exist for the page post type:

image

@gigitux
Copy link
Contributor Author

gigitux commented Sep 10, 2024

👋 Howdy @jameskoster!

I need your expertise with some UI/UX aspects for field controls. Here are the details:

Template Field Control

In the page editor, the template field control offers various options:

Screen.Capture.on.2024-09-10.at.15-53-32.mp4

Should we implement a similar design?

Password Field Control

The password field control is located in the status section of the page editor:

Screen.Capture.on.2024-09-10.at.15-55-30.mp4

Do you think it's worth replicating this functionality for the data view as well?

Thanks for your help!

@jameskoster
Copy link
Contributor

Template Field Control

In terms of the quick-edit panel I think the only option that makes sense here is swapping the template. Would it be possible to hide the other options?

Do you think it's worth replicating this functionality for the data view as well?

Yes I think so. See #49012.

@gigitux
Copy link
Contributor Author

gigitux commented Sep 10, 2024

In terms of the quick-edit panel I think the only option that makes sense here is swapping the template. Would it be possible to hide the other options?

Screen.Capture.on.2024-09-10.at.17-02-21.mp4

Should be this the experience?

Yes I think so. See #49012.

Great! 👍

Technically, those are two different fields of the page object. I'm wondering if this could be a good chance to explore the JSON Forms layout property: in particular way, the group layout.

cc @louwie17 @joshuatf

@jameskoster
Copy link
Contributor

Should be this the experience?

I think we can try that to start, seeing as it already exists. Currently the previews are populated with content from the current page, do you have any idea how that might work in the context of bulk selection? Should we use the first item in the selection for the preview? Or not use any data in the preview (blocks will just display placeholder content).

@oandregal oandregal changed the title [Data View - Detail Panel]: Site Editor - Page view: implements all the view/edit controls for the Page view DataForm: replicate DocumentInspector in QuickEdit Sep 26, 2024
@oandregal oandregal mentioned this issue Sep 26, 2024
21 tasks
@oandregal
Copy link
Member

I've updated a bit the issue description and reworded the title so its focus is clearer.

@gigitux
Copy link
Contributor Author

gigitux commented Oct 25, 2024

I marked as done the order field because we decided to keep it as an action in quick edit as well for now. You can find more details on this Slack thread: https://wordpress.slack.com/archives/C02QB2JS7/p1729765343839939

@gigitux
Copy link
Contributor Author

gigitux commented Dec 6, 2024

Given that the template field has been merged (#66591), this issue can be closed.

@gigitux gigitux closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Experimental Experimental feature or API.
Projects
None yet
Development

No branches or pull requests

5 participants