PluginSidebarMoreMenuItem component is not rendering anymore

[matiasbenedetto]

Description

PluginSidebarMoreMenuItem component is not rendering anymore.
This is causing users to be unable to access the plugin's menu.

Step-by-step reproduction instructions

1. Install and activate plugin using PluginSidebarMoreMenuItem to add a button like Create Block Theme plugin. Reference: https://github.com/WordPress/create-block-theme/blob/trunk/src/plugin-sidebar.js#L91-L100
2. Browse the site editor and check that the plugin's button is not rendering with Gutenberg trunk.
3. Switch to Gutenberg 19.7 (latest stable release) and observe that the button is rendering as expected.

Screenshots, screen recording, code snippet

Expected (Gutenberg 19.7)	Actual (Gutenberg trunk)

Environment info

• WordPress 6.7.1
• Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[matiasbenedetto]

I'm not 100% sure, but this issue could be caused by the changes added in #67162
cc. @youknowriad @ntsekouras

[matiasbenedetto]

I'm confirming that #67162 causes this issue.
If you want to confirm that:

• Install and activate 'Create Block Theme' plugin.
• Checkout trunk branch in the last commit before merging Site Editor: Unify layout with posts dataviews #67162 (git checkout d02c4b4cec4923bb1d97327d997da4a9c8d7fe75)
• Build Gutenberg npm run dev
• Browser the site editor and observe the plugin button.
• Checkout the commit where Site Editor: Unify layout with posts dataviews #67162 was merged into trunk: git checkout 758b750ee3347cba4f1d334d1ab378387657f837.
• Build Gutenberg npm run dev
• Browser the site editor and observe that the plugin plugin button is no longer there.

Commits timeline: