Site Editor: Unify layout with posts dataviews #67162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Nov 20, 2024
|
|
||
| export default function LayoutWithGlobalStylesProvider( props ) { | ||
| return ( | ||
| <GlobalStylesProvider> |
There was a problem hiding this comment.
Would love if we can get rid of "GlobalStylesProvider" at some point. It feels like something that should be absorbed into core-data at some point.
youknowriad
added
[Type] Code Quality
|
Size Change: -2 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Nov 21, 2024
| @@ -50,14 +44,9 @@ export default function App() { | |||
| } | |||
|
|
|||
| return ( | |||
| <SlotFillProvider> | |||
There was a problem hiding this comment.
Is the removal of SlotFillProvider here intentional?
There was a problem hiding this comment.
Yes, If I'm not wrong it's not really needed at the top level because of a refactor that I did to Slot/Fill at some point where slots will just get inserted under body anyway.
There was a problem hiding this comment.
I couldn't find where we add it. Do you mean here?
In edit-post we still have this top level.
There was a problem hiding this comment.
In edit-post we still have this top level.
Maybe it's not needed there as well. What issues does it create to drop it?
There was a problem hiding this comment.
I didn't observe any, but wanted to understand it better.
There was a problem hiding this comment.
Yes, since that PR you shared, the slot is optional now, Unless I'm missing something, I don't see this having any impact. the "posts dataviews" didn't have that wrapper.
There was a problem hiding this comment.
Could this removal be the cause to this issue? #67538
There was a problem hiding this comment.
Actually I restored it before merging but I'll take a look at that regression tomorrow.
There was a problem hiding this comment.
Confirming the issue: #67538 (comment)
ntsekouras
approved these changes
Nov 21, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 28, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
6 tasks
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ntsekouras <[email protected]>
ramonjd
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #67160
What?
Just some small refactoring to avoid duplicating code between the site editor and the experimental posts dataviews page.
Testing Instructions
No real functional changes here.