Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Block toolbar should be responsive #724

Closed
jasmussen opened this issue May 9, 2017 · 4 comments
Closed

Mobile: Block toolbar should be responsive #724

jasmussen opened this issue May 9, 2017 · 4 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Mobile Web Viewport sizes for mobile and tablet devices

Comments

@jasmussen
Copy link
Contributor

Related to #44 and probably best to wait for #660 to be merged: the block toolbar should be responsive.

Part of this is ensuring good positioning (perhaps always fixed at the top below a certain screen threshold) at small viewports.

Part of it is deciding which buttons are present. See also #705.

Part of it could be making the inline tools show up on select only, a la the mockups:

mobile

Probably necessary regardless — the ability to move some items into an overflow ellipsis menu.

@jasmussen jasmussen added the General Interface Parts of the UI which don't fall neatly under other labels. label May 9, 2017
@jasmussen jasmussen added this to the Beta milestone May 10, 2017
@jasmussen jasmussen added the Mobile Web Viewport sizes for mobile and tablet devices label May 22, 2017
@jasmussen jasmussen changed the title Mobile & Responsive: Block toolbar should be responsive Mobile: Block toolbar should be responsive May 22, 2017
@jasmussen jasmussen self-assigned this May 22, 2017
@jasmussen
Copy link
Contributor Author

Also this:

screen shot 2017-05-22 at 13 56 20

@jasmussen
Copy link
Contributor Author

So, here's a mockup of how our various toolbars could behave in a responsive setting:

responsive quick toolbar

Not included is the freeform block toolbar, because that's still in flux and will need more time in the oven.

The quick toolbars have these states:

  • Unscaled. Shown on wide viewports.
  • Compressed. Space between control groups collapses.
  • Responsive. Block level control groups collapse into a dropdown.

First question: can we achieve states 1 and 2 using flexbox?

Second question: can we achieve state 1 in a realistic amount of time?

In case question 2 is unfeasible, I have other ideas for how to tackle responsive toolbars, but this, I think is a good design. So very curious to hear your thoughts. CC: @youknowriad and @iseulde.

Can we use this polyfill to create CSS element queries? https://github.com/marcj/css-element-queries

@jasmussen jasmussen modified the milestones: May 29 to Jun 2, Beta Jun 5, 2017
jasmussen added a commit that referenced this issue Jun 6, 2017
@jasmussen
Copy link
Contributor Author

This is rather improved in the most recent push. As such I'm switching milestones.

@jasmussen jasmussen modified the milestones: Beta, Nice To Have, Beta Jun 7, 2017
@jasmussen jasmussen removed their assignment Jun 7, 2017
@jasmussen
Copy link
Contributor Author

Master is working well currently. Closing this as fixed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Mobile Web Viewport sizes for mobile and tablet devices
Projects
None yet
Development

No branches or pull requests

1 participant