Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block toolbar looks odd on mobile #7256

Closed
ellatrix opened this issue Jun 11, 2018 · 5 comments
Closed

Block toolbar looks odd on mobile #7256

ellatrix opened this issue Jun 11, 2018 · 5 comments
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Milestone

Comments

@ellatrix
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

When selecting a block, it looks like the toolbar appears for the next block. I’m guessing there’s some styling issues for the block toolbar, I’m not sure how it’s supposed to look.

To Reproduce
Steps to reproduce the behavior:

  1. Select a block in Gutenberg on mobile

Expected behavior
A clear and concise description of what you expected to happen.

Block toolbar to feel more connected.

Screenshots
If applicable, add screenshots to help explain your problem.

cd38cade-72b7-427a-a17c-8fe51f19b7cd
9606fc18-6734-4f60-ae1f-aeb534cc4751

The last picture shows also the two toolbars on desktop. Maybe on mobile these can be merge into one?

Desktop (please complete the following information):

  • OS: [e.g. iOS] iOS
  • Browser [e.g. chrome, safari] safari
  • Version [e.g. 22] latest

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • Please add the version of Gutenberg you are using in the description.
  • To report a security issue, please visit the WordPress HackerOne program: https://hackerone.com/wordpress.
@ellatrix ellatrix added the [Type] Bug An existing feature does not function as intended label Jun 11, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone Jun 14, 2018
@mtias mtias added the Mobile Web Viewport sizes for mobile and tablet devices label Jul 19, 2018
@ZebulanStanphill
Copy link
Member

There have been a lot of changes to the toolbar lately. Is this issue still relevant?

@mtias mtias added the Needs Testing Needs further testing to be confirmed. label Oct 27, 2018
@designsimply
Copy link
Member

Tested and confirmed using WordPress 4.9.8 and Gutenberg 4.2.0-rc.1 with iPhone 6S running iOS 12.0.1 that the toolbars appear below blocks on mobile.

Seen at http://alittletestblog.com/wp-admin/post.php?post=13999&action=edit using iPhone 6S running iOS 12.0.1.

Notes: if you tap at the top of a long block, the toolbar can become obscured. I noticed the movers are missing for floated images (reported at #11454).

@designsimply designsimply removed the Needs Testing Needs further testing to be confirmed. label Nov 3, 2018
@mtias
Copy link
Member

mtias commented Nov 4, 2018

@jasmussen @karmatosed can you look at this one please?

@jasmussen
Copy link
Contributor

I need additional information here, because although I agree this feels odd compared to how it looks on desktop, sadly this implementation is a technical necessity. Reason 1: If you longpress to select text to make it bold, the bold button if above the text will be obscured by the mobile copy paste popout menu. Reason 2: we cannot fix the toolbar to the top due to the gory technical reasons outlined here: #7479 (comment)

As such, what you see on mobile right now is intentional, and the best we can do within the boundaries of Mobile Safari. I would again encourage reading through #7479 (comment) in depth, because that comment outlines how we want to make it better, but we really can't yet.

@jasmussen
Copy link
Contributor

Closing this one as intentional pending changes to Mobile Safari. See #7479 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

6 participants