-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block toolbar looks odd on mobile #7256
Comments
There have been a lot of changes to the toolbar lately. Is this issue still relevant? |
Tested and confirmed using WordPress 4.9.8 and Gutenberg 4.2.0-rc.1 with iPhone 6S running iOS 12.0.1 that the toolbars appear below blocks on mobile. Seen at http://alittletestblog.com/wp-admin/post.php?post=13999&action=edit using iPhone 6S running iOS 12.0.1. Notes: if you tap at the top of a long block, the toolbar can become obscured. I noticed the movers are missing for floated images (reported at #11454). |
@jasmussen @karmatosed can you look at this one please? |
I need additional information here, because although I agree this feels odd compared to how it looks on desktop, sadly this implementation is a technical necessity. Reason 1: If you longpress to select text to make it bold, the bold button if above the text will be obscured by the mobile copy paste popout menu. Reason 2: we cannot fix the toolbar to the top due to the gory technical reasons outlined here: #7479 (comment) As such, what you see on mobile right now is intentional, and the best we can do within the boundaries of Mobile Safari. I would again encourage reading through #7479 (comment) in depth, because that comment outlines how we want to make it better, but we really can't yet. |
Closing this one as intentional pending changes to Mobile Safari. See #7479 (comment). |
Describe the bug
A clear and concise description of what the bug is.
When selecting a block, it looks like the toolbar appears for the next block. I’m guessing there’s some styling issues for the block toolbar, I’m not sure how it’s supposed to look.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Block toolbar to feel more connected.
Screenshots
If applicable, add screenshots to help explain your problem.
The last picture shows also the two toolbars on desktop. Maybe on mobile these can be merge into one?
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: