-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URLInput: Include date as context for link search results #8573
Comments
Testing this today. If I'm understanding correctly, the request is to include additional contextual information in the list of posts / pages presented as options when adding a link to text? It seems to me a reasonable request, but may need some design consideration for how to accommodate the additional information relative the title, especially if occupying the same space. |
+1 to this approach. How would it work for longer post titles? How would we indicate other CPTs, like pages? This does add a bit of extra cognitive load to the UI. Would there be a way of only showing this information if it's relevant? For instance, if I just have one piece of content with the title I've searched for, I probably don't need any additional context, but if I have multiple pieces of content in a search result, I might need more information in order to make an informed decision. Is there a way of supporting both of these use cases without creating an inconsistent interaction pattern? |
@paaljoachim interesting, thanks for taking the time to mock this. I do think perhaps just showing date works as a starting point. Perhaps this is a solid exploration into the next iteration? |
Post type may be confusing for some users—many people aren't super aware of the distinction between posts and pages, and if I only have one piece of content named "Hello world", then displaying the post type doesn't really give me any additional information I didn't already have. It might make sense to show post types only as a way of clarifying the decision between two pieces of content with the same title. In the same vein, it's probably only useful showing dates for posts—since pages and other types of content aren't tied to a date in the same way, this information just becomes visual clutter that doesn't help with the task at hand (selecting the right piece of content to link to.) A better solution to the problem could be to show dates for posts, and post types for all other types of content: Note that I've tweaked the colours here so they pass colour contrast checks, but we'll also want to consider how to make this interface as usable as possible for keyboard and screen reader users. There's some prior art in the original designs for the navigation menu block: It would probably be good to double-check to see if this is the best approach, or if we're alright with just having the current focus styling, rather than adding an explicit button. |
Discussed during today's Gutenberg design triage (registration required). We agreed that the classic editor approach (#8573 (comment)) seems to be the simplest and clearest solution. |
+1 for me on this...does anyone know if it is possible to hook into this functionality and add something like this as a plugin? |
This issues was discussed today during the Accessibility Team's weekly meeting: you can find the complete discussion here: https://wordpress.slack.com/archives/C02RP4X03/p1584117146464800. As already pointed out by @enriquesanchez, the current version of Gutenberg already adds more information to each option (such as the URL and the post type), so new mockups to understand where to add the post/page date are needed. During the discussion, more accessibility issues about the listing of available links where pointed out:
Here is the code of the corresponging element.
From a technical point of view, here is what is announced:
The information provided is probably not very clear to understand for a screen reader user: adding some screen-reader-only text would probably be useful to add context (especially if also the date of the post/page is added to the information already provided).
Best solution would be to first check that the entered string is a valid URL and then offer the ability to insert it as a link. Also, the option to add the URL is the only one with an icon to the left, so there's no visual uniformity.
The points above can be discussed in the context of the current issue, or they can be separated into new issues for better discussion. |
Just wanted to note that the permalink only provides useful information if permalinks are set to be pretty. For example, this is not helpful to the user But if set to be pretty it is helpful: Whereas a date would be helpful regardless of the site's permalink settings. |
I actually, in this case, think the type is more useful potentially than the date. This was worked on within the new interface a bit and I would love to have that reviewed over the older one that's linked previously for accessibility. @enriquesanchez do you think you could see about that happening the weekly triages for a11y? |
@karmatosed the new link creation UI was reviewed and discussed a couple of weeks ago (see #8573 (comment) above). Is there anything else that you'd like us to check? |
I have associated this include date as context issue with the link control issue being updated here: #23375 |
In today's triage meeting in Slack, the Design Team thought it would be good to include this work in the new LinkControl UI being explored here: #24021 and in the issue here: #23375 Basically trying out a date in the results dropdown. |
I think based on the work going on in navigation and the current link interface, that my advice would be to follow the work in #23375 and iterations there. Based on this and the new work going on with navigation, let me loop in @jasmussen for that consideration, I think swapping needs design for feedback label is good here. |
+1. Everyone okay to close this issue out in favor of the work going on there? Reopen if not. |
When we insert a link on a word(s), in the list of related links we don't have anymore the date of the article published or if it's a page or event.
That kind of information is important because we may want to make interlinking to older pages or understand if we're not linking to a past event for mistake.
thanks
Joao
The text was updated successfully, but these errors were encountered: