Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why can you collapse the Block Switcher? #9522

Closed
mintplugins opened this issue Aug 31, 2018 · 4 comments · Fixed by #19344
Closed

Why can you collapse the Block Switcher? #9522

mintplugins opened this issue Aug 31, 2018 · 4 comments · Fixed by #19344
Labels
[Feature] Block Transforms Block transforms from one block to another [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@mintplugins
Copy link

I'm unsure if this is a bug, or if the option serves a purpose I am not seeing.

When switching blocks, there's an option to collapse the pop-up. With it collapsed, it doesn't really seem to serve a true purpose, and might just be something that got overlooked.

why-is-this-here

@designsimply designsimply added [Type] Question Questions about the design or development of the editor. Needs Design Feedback Needs general design feedback. [Feature] Block Transforms Block transforms from one block to another labels Aug 31, 2018
@ZebulanStanphill
Copy link
Member

Style variations for blocks can be registered (and some core blocks come with a default set of variations, such as the Quote block), and these also appear in the block switcher:

image

That is why you can collapse the block transforms group.

@kjellr
Copy link
Contributor

kjellr commented Sep 3, 2018

Style variations for blocks can be registered (and some core blocks come with a default set of variations, such as the Quote block), and these also appear in the block switcher:
That is why you can collapse the block transforms group.

True, but we should be able to detect whether there are Block Styles and hide the dropdown indicator when there are none. In that case, it doesn't serve any real purpose. 👍

@kjellr kjellr removed the Needs Design Feedback Needs general design feedback. label Sep 3, 2018
@mtias mtias added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time and removed [Type] Question Questions about the design or development of the editor. labels Sep 3, 2018
@mtias mtias added this to the WordPress 5.0 milestone Oct 7, 2018
@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Oct 29, 2018
@jorgefilipecosta jorgefilipecosta added the [Status] In Progress Tracking issues with work in progress label Dec 3, 2018
@talldan talldan assigned talldan and unassigned talldan Feb 25, 2019
@gziolo gziolo added Needs Dev Ready for, and needs developer efforts and removed [Status] In Progress Tracking issues with work in progress labels Apr 24, 2019
@gziolo
Copy link
Member

gziolo commented Apr 24, 2019

This issue is waiting for a developer to take care of it. There is some prior work done by @milesdelliott in #9886 which got out of date and can be used as a base for the fix.

@Soean
Copy link
Member

Soean commented Feb 24, 2020

This issue will be fixed by #19344

Bildschirmfoto 2020-02-24 um 12 49 32

@Soean Soean removed Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Feb 24, 2020
@youknowriad youknowriad mentioned this issue Feb 24, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Transforms Block transforms from one block to another [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
10 participants